1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/transactions
epriestley e19c555913 Support (basic) commenting on Phriction documents
Summary:
Depends on D19659. Fixes T1894. Ref T13077. See PHI840.

  - Add an EditEngine, although it currently supports no fields.
  - Add (basic, top-level-only) commenting (we already had the table in the database).

This will probably create some issues. I'm most concerned about documents accumulating a ton of old, irrelevant comments over time which are hard to keep track of and no longer relevant. But I think this is probably a step forward in almost all cases, and a good thing on the balance.

This also moves us incrementally toward putting all editing on top of EditEngine.

Test Plan: {F5877347}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13077, T1894

Differential Revision: https://secure.phabricator.com/D19660
2018-09-12 13:20:52 -07:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
bulk Document how webhooks work 2018-02-09 13:57:19 -08:00
commentaction When accepting revisions, allow users to accept on behalf of a subset of reviewers 2017-03-22 14:25:04 -07:00
conduit Raise a tailored error when calling "transaction.search" with empty "phids" constraint 2018-08-03 14:29:36 -07:00
constants Add a rough "!history" email command to get an entire object history via email 2018-04-16 12:27:52 -07:00
controller Remove duplicate "Change Default Values" action in form editing workflow 2017-03-22 09:50:38 -07:00
data Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Add "Mute/Unmute" for subscribable objects 2018-02-08 11:06:22 -08:00
editengine Rename "PHUIDocumentViewPro" to "PHUIDocumentView" 2018-08-28 14:53:07 -07:00
editfield Improve UI and documentation for "Ignore Attributes" in Owners slightly 2018-05-08 14:03:30 -07:00
editor When a user takes actions while in a high security session, note it on the resulting transactions 2018-09-12 12:57:02 -07:00
edittype Accept null via conduit.edit to unassign a task 2018-01-31 15:33:52 -08:00
engineextension Index only the first 1,000 comments on any object 2018-06-22 17:41:05 -07:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception Raise a warning when mentioning a user in a comment on a draft revision 2018-03-12 17:03:14 -07:00
feed Hide "abraham landed Dxyz irresponsibly" stories from feed 2018-03-06 17:48:03 -08:00
interface Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Fix transaction queries using withComments() for transactions with no comments 2017-10-02 09:09:53 -07:00
replyhandler Modularize content sources 2016-03-26 11:59:45 -07:00
response Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview" 2018-09-11 13:30:10 -07:00
storage When a user takes actions while in a high security session, note it on the resulting transactions 2018-09-12 12:57:02 -07:00
typeahead Don't allow forms which can't create objects to be added to profile menus 2017-02-16 15:45:11 -08:00
view Support (basic) commenting on Phriction documents 2018-09-12 13:20:52 -07:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Modularize application transactions in Paste, mostly 2016-06-14 06:13:28 -07:00