1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-07 13:21:02 +01:00
phorge-phorge/src/applications/metamta
epriestley e2f0571104 Drop empty inbound mail at the beginning of the receive workflow, not inside object handlers
Summary:
Ref T920. Ref T7477. We currently drop empty mail only once it reaches the `ReplyHandler` layer.

I think no plausible receiver can ever do anything useful with this kind of mail, so we can safely drop it earlier and simplify some of the logic. After T7477, we'd end up throwing multiple exceptions if you sent empty mail to several valid receivers.

(I also want to move away from APIs oriented around raw addresses in more specialized layers, and this is one of the few callsites for raw mail address information.)

This requires updating some unit tests to actually have message bodies, since they failed with this error before hitting the other errors otherwise.

Test Plan: Used `bin/mail receive-test` to send empty mail, got appropriate "err:empty" out of it.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T7477, T920

Differential Revision: https://secure.phabricator.com/D19947
2019-01-04 13:50:21 -08:00
..
action When we fail to process mail, tell the user about it 2014-04-03 18:43:18 -07:00
adapter Remove all legacy configuration options for mailers 2019-01-03 04:09:21 -08:00
application Support Postmark inbound mail via webhook 2018-02-08 06:25:26 -08:00
applicationpanel Separate button CSS classes 2017-06-05 20:14:34 +00:00
command Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
constants Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Allow mailers to be explicitly marked as inbound or outbound 2018-07-30 08:25:06 -07:00
edge MetaMTA - more progress towards a mail application 2015-06-23 11:37:14 -07:00
editor Use ApplicationTransactions in ApplicationEmail 2015-06-11 10:15:49 -07:00
engine Add basic support for mail "stamps" to improve client mail routing 2018-02-06 04:04:13 -08:00
engineextension Manage object mailKeys automatically in Mail instead of storing them on objects 2018-04-25 06:46:58 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
future Add a parameterized Future for Twilio API calls 2019-01-04 13:42:52 -08:00
garbagecollector Support DestructionEngine in MetaMTAMail 2018-02-02 14:37:33 -08:00
herald Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
management Allow mailers to be explicitly marked as inbound or outbound 2018-07-30 08:25:06 -07:00
parser Extend from Phobject 2015-06-15 18:02:27 +10:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Fix a qsprintf() issue in mail queries 2019-01-02 14:39:31 -08:00
receiver Drop empty inbound mail at the beginning of the receive workflow, not inside object handlers 2019-01-04 13:50:21 -08:00
replyhandler Drop empty inbound mail at the beginning of the receive workflow, not inside object handlers 2019-01-04 13:50:21 -08:00
stamp Fix a mail stamp issue with blocking reviewers 2018-02-13 17:56:21 -08:00
storage Drop empty inbound mail at the beginning of the receive workflow, not inside object handlers 2019-01-04 13:50:21 -08:00
typeahead Fix packages(project) to work properly and add it to "MailableFunctionDatasource" 2018-10-19 13:53:27 -07:00
view Remove defunct "metamta.herald.show-hints" Config option 2018-11-26 10:14:25 -08:00
PhabricatorMetaMTAWorker.php Send permanent dameon failures to the log, even when not running in verbose mode 2017-06-08 15:26:19 -07:00