1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 12:12:43 +01:00
phorge-phorge/src/applications/auth/controller
Andre Klapper e3ad37f792 Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15311

Test Plan:
Applied this change (on top of D25144, D25145, D25146, D25147, D25151,
D25152, D25153) and `Upload SSH Public key` dialog rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15311

Differential Revision: https://we.phorge.it/D25161
2023-05-01 01:08:28 +02:00
..
config Remove product literal strings in "pht()", part 12 2022-04-25 16:46:24 -07:00
contact Remove product literal strings in "pht()", part 2 2022-04-25 12:22:26 -07:00
message Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both 2019-07-19 15:39:21 -07:00
mfa Fix an issue with Duo not live-updating properly on login gates 2019-03-29 11:00:38 -07:00
PhabricatorAuthConfirmLinkController.php Remove product literal strings in "pht()", part 11 2022-04-25 16:46:24 -07:00
PhabricatorAuthController.php Remove product literal strings in "pht()", part 1 2022-04-25 12:22:25 -07:00
PhabricatorAuthDowngradeSessionController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00
PhabricatorAuthFinishController.php Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
PhabricatorAuthInviteController.php Support invites in the registration and login flow 2015-02-11 06:06:28 -08:00
PhabricatorAuthLinkController.php Remove product literal strings in "pht()", part 11 2022-04-25 16:46:24 -07:00
PhabricatorAuthLoginController.php Remove product literal strings in "pht()", part 12 2022-04-25 16:46:24 -07:00
PhabricatorAuthNeedsApprovalController.php Add support for custom "Wait for Approval" instructions 2019-05-16 10:41:52 -07:00
PhabricatorAuthNeedsMultiFactorController.php Remove product literal strings in "pht()", part 12 2022-04-25 16:46:24 -07:00
PhabricatorAuthOldOAuthRedirectController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00
PhabricatorAuthOneTimeLoginController.php Remove product literal strings in "pht()", part 1 2022-04-25 12:22:25 -07:00
PhabricatorAuthRegisterController.php Fix PHP 8.1 "strlen(null)" exceptions to render the Account Creation page 2023-04-29 21:54:57 +02:00
PhabricatorAuthRevokeTokenController.php Clean up redirect URIs for "Temporary Tokens" and "API Tokens" settings panels 2016-06-28 14:51:04 -07:00
PhabricatorAuthSetExternalController.php Remove product literal strings in "pht()", part 12 2022-04-25 16:46:24 -07:00
PhabricatorAuthSetPasswordController.php Move account passwords to shared infrastructure 2018-01-23 13:43:07 -08:00
PhabricatorAuthSSHKeyController.php Add ViewController and SearchEngine for SSH Public Keys 2016-05-19 09:48:46 -07:00
PhabricatorAuthSSHKeyEditController.php Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog 2023-05-01 01:08:28 +02:00
PhabricatorAuthSSHKeyGenerateController.php Remove product literal strings in "pht()", part 1 2022-04-25 12:22:25 -07:00
PhabricatorAuthSSHKeyListController.php Add ViewController and SearchEngine for SSH Public Keys 2016-05-19 09:48:46 -07:00
PhabricatorAuthSSHKeyRevokeController.php Add a bin/auth revoke revoker for SSH keys 2018-01-22 15:35:07 -08:00
PhabricatorAuthSSHKeyViewController.php Add a bin/auth revoke revoker for SSH keys 2018-01-22 15:35:07 -08:00
PhabricatorAuthStartController.php Remove product literal strings in "pht()", part 12 2022-04-25 16:46:24 -07:00
PhabricatorAuthTerminateSessionController.php Upgrade sessions digests to HMAC256, retaining compatibility with old digests 2018-12-13 16:15:38 -08:00
PhabricatorAuthUnlinkController.php Remove product literal strings in "pht()", part 12 2022-04-25 16:46:24 -07:00
PhabricatorAuthValidateController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00
PhabricatorDisabledUserController.php Update Auth for new UI 2016-03-31 13:51:12 -07:00
PhabricatorEmailLoginController.php Record account recovery email links in the user activity log and make the mail message reference the log 2019-07-24 07:13:34 -07:00
PhabricatorEmailVerificationController.php Remove product literal strings in "pht()", part 2 2022-04-25 12:22:26 -07:00
PhabricatorLogoutController.php When users try to log out with no providers configured, warn them of the consequences 2019-09-08 12:27:29 -07:00
PhabricatorMustVerifyEmailController.php Remove product literal strings in "pht()", part 12 2022-04-25 16:46:24 -07:00
PhabricatorRefreshCSRFController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00