1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications/legalpad
epriestley f0364eef8a Remove weird integration between Legalpad and the ExternalAccount table
Summary:
Depends on D20107. Ref T6703. Legalpad currently inserts "email" records into the external account table, but they're never used for anything and nothing else references them.

They also aren't necessary for anything important to work, and the only effect they have is making the UI say "External Account" instead of "None" under the "Account" column. In particular, the signatures still record the actual email address.

Stop doing this, remove all the references, and destroy all the rows.

(Long ago, Maniphest may also have done this, but no longer does. Nuance/Gatekeeper use a more modern and more suitable "ExternalObject" thing that I initially started adapting here before realizing that Legalpad doesn't actually care about this data.)

Test Plan: Signed documents with an email address, saw signature reflected properly in UI. Grepped for other callsites.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T6703

Differential Revision: https://secure.phabricator.com/D20108
2019-02-07 15:00:00 -08:00
..
application Update Legalpad to use comment transactions 2017-05-11 10:14:13 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
controller Remove weird integration between Legalpad and the ExternalAccount table 2019-02-07 15:00:00 -08:00
edge Modernize Legalpad edge types 2015-01-01 11:15:34 +11:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
herald Various translation improvements 2015-11-03 07:02:46 +11:00
mail Allow multiple mail receivers to react to an individual email 2019-01-16 12:28:02 -08:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
policyrule Move some files around 2015-11-17 06:26:13 +11:00
query Remove weird integration between Legalpad and the ExternalAccount table 2019-02-07 15:00:00 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
storage Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
typeahead Give typeahead browse dialogs sensible titles 2015-04-20 10:06:23 -07:00
xaction Add spelling TODOs 2017-10-09 11:56:53 -07:00