1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-26 06:28:19 +01:00
phorge-phorge/src/applications/differential/view
epriestley e5906f4e12 In Differential standalone views, disable some keyboard shortcuts which don't work
Summary:
Ref T13164. See PHI693. In Differential, you can {nav View Options > View Standalone} to get a standalone view of a single changeset. You can also arrive here via the big changeset list for revisions affecting a huge number of files.

We currently suggest that all the keyboard shortcuts work, but some do not. In particular, the "Next File" and "Previous File" keyboard shortcuts (and some similar shortcuts) do not work. In the main view, the next/previous files are on the same page. In the standalone view, we'd need to actually change the URI.

Ideally, we should do this (and, e.g., put prev/next links on the page). As a first step toward that, hide the nonfunctional shortcuts to stop users from being misled.

Test Plan:
  - Viewed a revision in normal and standalone views.
  - No changes in normal view, and all keys still work ("N", "P", etc).
  - In standalone view, "?" no longer shows nonfunctional key commands.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13164

Differential Revision: https://secure.phabricator.com/D19571
2018-08-13 08:59:05 -07:00
..
DifferentialChangesetDetailView.php Add inline comment counts to the filetree view 2018-02-08 17:15:36 -08:00
DifferentialChangesetFileTreeSideNavBuilder.php Make the filetree view width sticky across show/hide and reload 2018-02-22 13:47:41 -08:00
DifferentialChangesetListView.php In Differential standalone views, disable some keyboard shortcuts which don't work 2018-08-13 08:59:05 -07:00
DifferentialLocalCommitsView.php Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions" 2016-06-30 18:50:52 -07:00
DifferentialReviewersView.php Refine bucketing and display rules for voided "Accepts" in Differential 2017-11-07 15:35:11 -08:00
DifferentialRevisionListView.php Improve color use in "[+++- ]" element for colorblind users 2018-04-19 17:24:44 -07:00
DifferentialRevisionUpdateHistoryView.php Add a "Changes Since Last Action" view to Differential revisions 2018-07-27 12:27:33 -07:00
DifferentialTransactionView.php Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00