1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-28 20:18:13 +01:00
phorge-phorge/webroot/rsrc
epriestley e5906f4e12 In Differential standalone views, disable some keyboard shortcuts which don't work
Summary:
Ref T13164. See PHI693. In Differential, you can {nav View Options > View Standalone} to get a standalone view of a single changeset. You can also arrive here via the big changeset list for revisions affecting a huge number of files.

We currently suggest that all the keyboard shortcuts work, but some do not. In particular, the "Next File" and "Previous File" keyboard shortcuts (and some similar shortcuts) do not work. In the main view, the next/previous files are on the same page. In the standalone view, we'd need to actually change the URI.

Ideally, we should do this (and, e.g., put prev/next links on the page). As a first step toward that, hide the nonfunctional shortcuts to stop users from being misled.

Test Plan:
  - Viewed a revision in normal and standalone views.
  - No changes in normal view, and all keys still work ("N", "P", etc).
  - In standalone view, "?" no longer shows nonfunctional key commands.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13164

Differential Revision: https://secure.phabricator.com/D19571
2018-08-13 08:59:05 -07:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css Add a more specific CSS rule to make Spaces headers in projects colored red 2018-07-31 10:23:35 -07:00
externals Fix Javascript busy loop when trying to delete tokens from an empty tokenizer 2018-06-01 14:51:06 -07:00
favicons Dynamically composite favicons from customizable sources 2018-03-12 15:28:41 -07:00
image Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
js In Differential standalone views, disable some keyboard shortcuts which don't work 2018-08-13 08:59:05 -07:00