1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
phorge-phorge/src/applications/herald/action
epriestley d60d4e6a05 Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them
Summary:
Fixes T7961. Currently, we present Herald users with actions like "Require legalpad signatures" and "Run build plans" even if Legalpad and Harbormaster are not installed.

Instead, allow fields and actions to be made "unavailable", which means that we won't present them as options when adding to new or existing rules.

If you edit a rule which already uses one of these fields or actions, it isn't affected.

Test Plan:
  - Created a rule with a legalpad action, uninstalled legalpad, edited the rule. Action remained untouched.
  - Created a new rule, wasn't offered the legalpad action.
  - Reinstalled the application, saw the action again.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T7961

Differential Revision: https://secure.phabricator.com/D20808
2019-09-12 14:33:28 -07:00
..
HeraldAction.php Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
HeraldActionGroup.php Use getPhobjectClassConstant() to access class constants 2015-10-01 16:56:21 -07:00
HeraldApplicationActionGroup.php Modularize Maniphest Herald "Assign Task" action 2015-08-03 14:33:25 -07:00
HeraldCallWebhookAction.php Index "Call Webhook" in Herald, and show calling rules on the Webhook page 2019-03-07 14:48:14 -08:00
HeraldCommentAction.php Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
HeraldDoNothingAction.php Modularize the Diffusion "Add Auditors" Herald action 2015-08-03 14:33:27 -07:00
HeraldNotifyActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
HeraldPreventActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
HeraldSupportActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
HeraldUtilityActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00