1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 17:58:47 +02:00
phorge-phorge/src/applications/diffusion
epriestley e81637a6c6 Fix some issues with the "Explain Why" dialog
Summary:
Ref T11051. This is still not as clear as it should be, but is at least working as intended now.

I believe this part of the code just never worked. The test plan on D10489 didn't specifically cover it.

Test Plan:
Did this sort of thing in a repository:

```
$ git checkout -b featurex
$ echo x >> y
$ git commit -am wip
$ arc diff
```

Then I simulated just pushing it (this flow is a little more involved than necessary):

```
$ arc land --hold
$ git commit --amend
$ # remove all metadata -- particularly, "Differential Revision"!
$ git push HEAD:master
```

I got a not-great but more-useful dialog:

{F1667318}

Prior to this change, the hash match was incorrectly not reported at all.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11051

Differential Revision: https://secure.phabricator.com/D15989
2016-05-30 09:52:35 -07:00
..
application Sort out EditController / ManageController / EditproController Diffusion hierarchy 2016-05-10 05:14:09 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Add diffusion.uri.edit for creating and editing repository URIs 2016-04-29 13:55:48 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller Improve audit behavior for "uninteresting" auditors 2016-05-17 13:47:33 -07:00
data Provide a more consistent, mostly relaxed severity for updating non-cluster repositories on cluster devices 2016-05-12 15:51:14 -07:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Fix reverting commit language 2015-06-01 09:54:30 +10:00
editor Prevent users from disabling repository builtin URIs 2016-05-12 12:09:23 -07:00
engine When observing a repository, switch to "importing" mode on a large discovery in an empty repository 2016-05-11 06:36:38 -07:00
engineextension Fix an issue with URI index updates from the daemons 2016-05-13 06:51:31 -07:00
exception Make repository daemon locks more granular and forgiving 2016-05-13 05:17:27 -07:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
gitlfs Implement a Git LFS link table and basic batch API 2016-03-17 17:15:20 -07:00
herald Improve audit behavior for "uninteresting" auditors 2016-05-17 13:47:33 -07:00
management Put "Projects" edit field back on Basics management panel for repositories 2016-05-12 07:17:14 -07:00
panel Add "Mailing List" users 2015-06-03 18:42:33 -07:00
protocol Fix a possible fatal on the first push to a cluster repository 2016-05-23 17:54:54 -07:00
query Fix some issues with the "Explain Why" dialog 2016-05-30 09:52:35 -07:00
remarkup Stop all object mentions from matching after "@" 2015-09-29 06:43:49 -07:00
request Rough sketch of new repository URI editing 2016-04-29 09:21:00 -07:00
response Implement a Git LFS server which supports no operations 2016-03-17 08:08:43 -07:00
ssh Fix improper viewer for Git SSH cluster workflows 2016-05-11 18:02:02 -07:00
symbol Extend from Phobject 2015-06-15 18:02:27 +10:00
typeahead Improve type and icon information in typeahead 2016-02-05 12:48:20 -08:00
view Clean up display of clone URIs a little bit 2016-05-11 13:14:55 -07:00
DiffusionLintSaveRunner.php Move repository URIs to a dedicated index 2016-01-13 09:34:31 -08:00