1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/feed
David Fisher e846a1747e Fix Feed Times on 32 Bit Servers
Summary:
The feed time is stored as the upper 32 bits of
PhabricatorFeedStoryData::chronologicalKey. These bits were previously accessed
by right shifting, which does not work properly on 32 bit machines (the result
is PHP_INT_MAX). We now attempt to use the bc extension (if available) and fall
back on mysql math otherwise. (See T500, D912).

Test Plan:
The calculation is unchanged for 64 bit machines. I checked both
paths on a 32 bit machine with bc extension available by setting the appropriate
if-condition to false and true.

Reviewers: epriestley

Reviewed By: epriestley

CC: ddfisher, aran, epriestley

Differential Revision: https://secure.phabricator.com/D1726
2012-02-28 21:04:02 -08:00
..
builder/feed Resolve link framing issue for public feed 2012-01-30 04:12:15 -08:00
constants Integrate Audit into feed 2012-02-27 09:49:01 -08:00
controller Add a "feed" filter to the home page; align things; allow browsing older stories 2012-02-15 17:48:14 -08:00
publisher Fix generateChronologicalKey() for 32-bit machines 2011-09-14 09:03:45 -07:00
query Add a "feed" filter to the home page; align things; allow browsing older stories 2012-02-15 17:48:14 -08:00
storage Fix Feed Times on 32 Bit Servers 2012-02-28 21:04:02 -08:00
story Integrate Audit into feed 2012-02-27 09:49:01 -08:00
view Publish Differential stories into feed 2011-07-09 17:39:17 -07:00