mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 10:22:42 +01:00
e846a1747e
Summary: The feed time is stored as the upper 32 bits of PhabricatorFeedStoryData::chronologicalKey. These bits were previously accessed by right shifting, which does not work properly on 32 bit machines (the result is PHP_INT_MAX). We now attempt to use the bc extension (if available) and fall back on mysql math otherwise. (See T500, D912). Test Plan: The calculation is unchanged for 64 bit machines. I checked both paths on a 32 bit machine with bc extension available by setting the appropriate if-condition to false and true. Reviewers: epriestley Reviewed By: epriestley CC: ddfisher, aran, epriestley Differential Revision: https://secure.phabricator.com/D1726 |
||
---|---|---|
.. | ||
builder/feed | ||
constants | ||
controller | ||
publisher | ||
query | ||
storage | ||
story | ||
view |