1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/differential
Bob Trahan e8985fc9e7 Differential - change "closed by commit" comment to real transaction
Summary:
Implements a new transaction - still TYPE_ACTION - but using a new DifferentialAction::ACTION_COMMIT_CLOSE. Augment rendering as necessary to display this new transaction. Saves enough information so T3686 is possible but stops short of implementing a popup to display this information. Fixes T5875. Ref T3686.

One small display oddity - this new transaction now renders at the top of the transaction group whereas when it was a comment it was on the bottom. I think this is basically okay but if not how fix? (Playing with the "strength" of these actions will mess up the email too?)

Test Plan: made a diff X that fixed task Y. committed. checked diff X, task Y, and the commit pages for proper transactions and all looked good.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T3686, T5875

Differential Revision: https://secure.phabricator.com/D10485
2014-09-12 10:12:52 -07:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Rename policy capabilities 2014-07-25 08:20:39 +10:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Allow Herald "diff" rules to reject content before it is written 2014-08-20 14:26:29 -07:00
config Add an option to put comment context into emails. 2014-08-15 10:14:09 -07:00
constants Differential - change "closed by commit" comment to real transaction 2014-09-12 10:12:52 -07:00
controller Don't require an actor in PhabricatorFile::attachToObject() 2014-09-04 12:51:33 -07:00
customfield Spell "dependendency" less incorrecter 2014-07-30 12:59:28 -07:00
doorkeeper Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
edge Modernize task/revision edges and write inverse transactions 2014-07-17 15:41:08 -07:00
editor Transactions - add infrastructure for "mentions" 2014-09-09 14:21:13 -07:00
event phutil_utf8_shorten => PhutilUTF8StringTruncator 2014-08-29 15:15:13 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Rename policy capabilities 2014-07-25 08:20:39 +10:00
lipsum Use DifferentialRevisionEditor in lipsum 2014-03-11 13:02:00 -07:00
mail Revert attempt to fix mail in differential 2014-07-31 14:54:43 -07:00
management Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
parser phutil_utf8_shorten => PhutilUTF8StringTruncator 2014-08-29 15:15:13 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Allow searching diffs by more status options 2014-07-30 13:55:05 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Clean up image file diffs UI 2014-08-19 14:46:37 -07:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Differential - change "closed by commit" comment to real transaction 2014-09-12 10:12:52 -07:00
view Fix some long lines to be less long 2014-09-08 23:08:56 +10:00
DifferentialGetWorkingCopy.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00