mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 20:02:40 +01:00
023dee0d3b
Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method. Test Plan: ``` > echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami Waiting for JSON parameters on stdin... {"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}} ``` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin, hach-que Maniphest Tasks: T5655 Differential Revision: https://secure.phabricator.com/D9991
79 lines
2 KiB
PHP
79 lines
2 KiB
PHP
<?php
|
|
|
|
final class DifferentialUpdateRevisionConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.updaterevision';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Update a Differential revision.');
|
|
}
|
|
|
|
public function defineParamTypes() {
|
|
return array(
|
|
'id' => 'required revisionid',
|
|
'diffid' => 'required diffid',
|
|
'fields' => 'required dict',
|
|
'message' => 'required string',
|
|
);
|
|
}
|
|
|
|
public function defineReturnType() {
|
|
return 'nonempty dict';
|
|
}
|
|
|
|
public function defineErrorTypes() {
|
|
return array(
|
|
'ERR_BAD_DIFF' => 'Bad diff ID.',
|
|
'ERR_BAD_REVISION' => 'Bad revision ID.',
|
|
'ERR_WRONG_USER' => 'You are not the author of this revision.',
|
|
'ERR_CLOSED' => 'This revision has already been closed.',
|
|
);
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$viewer = $request->getUser();
|
|
|
|
$diff = id(new DifferentialDiffQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($request->getValue('diffid')))
|
|
->executeOne();
|
|
if (!$diff) {
|
|
throw new ConduitException('ERR_BAD_DIFF');
|
|
}
|
|
|
|
$revision = id(new DifferentialRevisionQuery())
|
|
->setViewer($request->getUser())
|
|
->withIDs(array($request->getValue('id')))
|
|
->needReviewerStatus(true)
|
|
->needActiveDiffs(true)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->executeOne();
|
|
if (!$revision) {
|
|
throw new ConduitException('ERR_BAD_REVISION');
|
|
}
|
|
|
|
if ($revision->getStatus() == ArcanistDifferentialRevisionStatus::CLOSED) {
|
|
throw new ConduitException('ERR_CLOSED');
|
|
}
|
|
|
|
$this->applyFieldEdit(
|
|
$request,
|
|
$revision,
|
|
$diff,
|
|
$request->getValue('fields', array()),
|
|
$request->getValue('message'));
|
|
|
|
return array(
|
|
'revisionid' => $revision->getID(),
|
|
'uri' => PhabricatorEnv::getURI('/D'.$revision->getID()),
|
|
);
|
|
}
|
|
|
|
}
|