mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-21 13:00:56 +01:00
7f98a8575d
Summary: Ref T5681. Policy rules can now select objects they can apply to, so a rule like "task author" only shows up where it makes sense (when defining task policies). This will let us define rules like "members of thread" in Conpherence, "subscribers", etc., to make custom policies more flexible. Notes: - Per D13251, we need to do a little work to get the right options for policies like "Maniphest > Default View Policy". This should allow "task" policies. - This implements a "task author" policy as a simple example. - The `willApplyRule()` signature now accepts `$objects` to support bulk-loading things like subscribers. Test Plan: - Defined a task to be "visible to: task author", verified author could see it and other users could not. - `var_dump()`'d willApplyRule() inputs, verified they were correct (exactly the objects which use the rule). - Set `default view policy` to a task-specific policy. - Verified that other policies like "Can Use Bulk Editor" don't have these options. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5681 Differential Revision: https://secure.phabricator.com/D13252
130 lines
3.2 KiB
JavaScript
130 lines
3.2 KiB
JavaScript
/**
|
|
* @provides javelin-behavior-policy-control
|
|
* @requires javelin-behavior
|
|
* javelin-dom
|
|
* javelin-util
|
|
* phuix-dropdown-menu
|
|
* phuix-action-list-view
|
|
* phuix-action-view
|
|
* javelin-workflow
|
|
* @javelin
|
|
*/
|
|
JX.behavior('policy-control', function(config) {
|
|
var control = JX.$(config.controlID);
|
|
var input = JX.$(config.inputID);
|
|
var value = config.value;
|
|
|
|
var menu = new JX.PHUIXDropdownMenu(control)
|
|
.setWidth(260)
|
|
.setAlign('left');
|
|
|
|
menu.listen('open', function() {
|
|
var list = new JX.PHUIXActionListView();
|
|
|
|
for (var ii = 0; ii < config.groups.length; ii++) {
|
|
var group = config.groups[ii];
|
|
|
|
list.addItem(
|
|
new JX.PHUIXActionView()
|
|
.setName(config.labels[group])
|
|
.setLabel(true));
|
|
|
|
for (var jj = 0; jj < config.order[group].length; jj++) {
|
|
var phid = config.order[group][jj];
|
|
|
|
var onselect;
|
|
if (group == 'custom') {
|
|
onselect = JX.bind(null, function(phid) {
|
|
var uri = get_custom_uri(phid, config.capability);
|
|
|
|
new JX.Workflow(uri)
|
|
.setHandler(function(response) {
|
|
if (!response.phid) {
|
|
return;
|
|
}
|
|
|
|
replace_policy(phid, response.phid, response.info);
|
|
select_policy(response.phid);
|
|
})
|
|
.start();
|
|
|
|
}, phid);
|
|
} else {
|
|
onselect = JX.bind(null, select_policy, phid);
|
|
}
|
|
|
|
var option = config.options[phid];
|
|
var item = new JX.PHUIXActionView()
|
|
.setName(option.name)
|
|
.setIcon(option.icon + ' darkgreytext')
|
|
.setHandler(JX.bind(null, function(fn, e) {
|
|
e.prevent();
|
|
menu.close();
|
|
fn();
|
|
}, onselect));
|
|
|
|
if (phid == value) {
|
|
item.setSelected(true);
|
|
}
|
|
|
|
list.addItem(item);
|
|
}
|
|
}
|
|
|
|
menu.setContent(list.getNode());
|
|
});
|
|
|
|
|
|
var select_policy = function(phid) {
|
|
JX.DOM.setContent(
|
|
JX.DOM.find(control, 'span', 'policy-label'),
|
|
render_option(phid));
|
|
|
|
input.value = phid;
|
|
value = phid;
|
|
};
|
|
|
|
|
|
var render_option = function(phid, with_title) {
|
|
var option = config.options[phid];
|
|
|
|
var name = option.name;
|
|
if (with_title && (option.full != option.name)) {
|
|
name = JX.$N('span', {title: option.full}, name);
|
|
}
|
|
|
|
return [JX.$H(config.icons[option.icon]), name];
|
|
};
|
|
|
|
|
|
/**
|
|
* Get the workflow URI to create or edit a policy with a given PHID.
|
|
*/
|
|
var get_custom_uri = function(phid, capability) {
|
|
var uri = config.editURI;
|
|
if (phid != config.customPlaceholder) {
|
|
uri += phid + '/';
|
|
}
|
|
uri += '?capability=' + capability;
|
|
return uri;
|
|
};
|
|
|
|
|
|
/**
|
|
* Replace an existing policy option with a new one. Used to swap out custom
|
|
* policies after the user edits them.
|
|
*/
|
|
var replace_policy = function(old_phid, new_phid, info) {
|
|
config.options[new_phid] = info;
|
|
for (var k in config.order) {
|
|
for (var ii = 0; ii < config.order[k].length; ii++) {
|
|
if (config.order[k][ii] == old_phid) {
|
|
config.order[k][ii] = new_phid;
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
|
|
});
|