1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/externals/javelin/lib
epriestley 02315c4c48 Fix double-close on dialogs leading to Javascript console error
Summary:
Ref T13302. The "Close/Cancel" button is currently running two copies of the "dismiss dialog" code, since it's techncally a link with a valid HREF attribute.

An alternate formulation of this is perhaps `if (JX.Stratcom.pass()) { return; }` ("let other handlers react to this event; if something kills it, stop processing"), but `pass()` is inherently someone spooky/fragile so try to get away without it.

Test Plan: Opened the Javascript console, clicked "Edit Task" on a workboard, clicked "Close" on the dialog. Before: event was double-handled leading to a JS error in the console. After: dialog closes uneventfully.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13302

Differential Revision: https://secure.phabricator.com/D20640
2019-07-03 12:38:49 -07:00
..
__tests__ Remove an unused variable 2015-01-20 21:25:40 +11:00
control Fix Javascript busy loop when trying to delete tokens from an empty tokenizer 2018-06-01 14:51:06 -07:00
behavior.js Fix "Actions" button on Phame standalone/live pages (bonus: JX.sprintf()) 2019-04-04 06:10:14 -07:00
Cookie.js Fix another undefined variable 2015-01-20 08:55:04 +11:00
DOM.js Move the "select a line range" inline code to DiffInline 2017-05-17 08:41:26 -07:00
History.js Fix an issue with returning to a the initial page in Quicksand 2015-03-28 07:38:14 -07:00
JSON.js Remove @group annotations 2014-07-10 08:12:48 +10:00
Leader.js Decrease JX.Leader lease duration from 16,000ms to 1,500ms and usurp more aggressively 2017-04-17 15:48:47 -07:00
Mask.js Remove @group annotations 2014-07-10 08:12:48 +10:00
Quicksand.js When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI 2015-12-17 08:30:03 -08:00
Request.js Really fix movable panels inside tab panels by changing the JX.Request serializer 2019-05-01 15:38:40 -07:00
Resource.js Fix various lint issues in rJX 2015-01-14 07:59:56 +11:00
Routable.js Provide a global router for Ajax requests 2014-05-05 10:57:42 -07:00
Router.js Provide a global router for Ajax requests 2014-05-05 10:57:42 -07:00
Scrollbar.js Hide the Differential scroll objective list on trackpad systems 2017-05-20 07:56:21 -07:00
Sound.js Add a "Play Sound" workboard trigger rule 2019-03-25 14:03:57 -07:00
URI.js When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI 2015-12-17 08:30:03 -08:00
Vector.js Fix anchor-clicking scroll positions 2015-01-28 08:26:10 -08:00
WebSocket.js When disconnected from Aphlict after a successful connection, retry the first reconnect right away 2017-04-17 15:53:29 -07:00
Workflow.js Fix double-close on dialogs leading to Javascript console error 2019-07-03 12:38:49 -07:00