mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-23 02:38:48 +02:00
cd9d59344c
Summary: The flow was off in some cases. This should mitigate it. Adds a Unicode musical note character at the start of the rap which, when clicked, embeds a song in the background, hides it and plays it. Currently the song is Gangsta's Paradise (karaoke version) but if you'd prefer a different song, I can probably change it with only a few weeks of work. This doesn't respect the "embed youtubes" preference because you have to click something to embed it, so it's your own fault your referers are getting leaked. For now, does the simplest thing and doesn't loop it. If it turns out people are spending a lot of time on this page, we should look into doing something like youtuberepeater. Not trying to make this share code with the existing Youtube embedding stuff - I think they're doing different enough things that solving them both in the same way would be more code. Test Plan: Clicked the note in Firefox. Clicked the note in Chrome. Considered clicking the note in Safari and Internet Explorer. Reviewers: epriestley Reviewed By: epriestley CC: miorel, HarrisonW, aran, Korvin Differential Revision: https://secure.phabricator.com/D4437 |
||
|---|---|---|
| .. | ||
| PhabricatorSettingsPanel.php | ||
| PhabricatorSettingsPanelAccount.php | ||
| PhabricatorSettingsPanelConduit.php | ||
| PhabricatorSettingsPanelDisplayPreferences.php | ||
| PhabricatorSettingsPanelEmailAddresses.php | ||
| PhabricatorSettingsPanelEmailPreferences.php | ||
| PhabricatorSettingsPanelLDAP.php | ||
| PhabricatorSettingsPanelOAuth.php | ||
| PhabricatorSettingsPanelPassword.php | ||
| PhabricatorSettingsPanelProfile.php | ||
| PhabricatorSettingsPanelSearchPreferences.php | ||
| PhabricatorSettingsPanelSSHKeys.php | ||