1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/differential/view
epriestley e9f4a84a89 Allow inline comments to be individually hidden
Summary:
Ref T7447. Implements per-viewer comment hiding. Once a comment is obsolete or uninteresting, you can hide it completely.

This is sticky per-user.

My hope is that this will strike a better balance between concerns than some of the other approaches (conservative porting, summarization, hide-all).

Specifically, this adds a new action here:

{F435621}

Clicking it completely collapses the comment into a small icon on the previous line, and saves the comment state as hidden for you:

{F435626}

You can click the icon to reveal all hidden comments below the line.

Test Plan:
  - Hid comments.
  - Showed comments.
  - Created, edited, deleted and submitted comments.
  - Used Diffusion comments (hiding is not implemented there yet, but I'd plan to bring it there eventually if it works out in Differential).

Reviewers: btrahan, chad

Reviewed By: btrahan

Subscribers: jparise, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D13009
2015-05-27 10:28:38 -07:00
..
DifferentialAddCommentView.php Require TokenizerControl to always have a datasource 2015-04-20 10:06:13 -07:00
DifferentialChangesetDetailView.php Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
DifferentialChangesetFileTreeSideNavBuilder.php
DifferentialChangesetListView.php Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
DifferentialDiffTableOfContentsView.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialLocalCommitsView.php Use PhutilInvalidStateException 2015-05-14 07:53:52 +10:00
DifferentialPrimaryPaneView.php
DifferentialResultsTableView.php
DifferentialReviewersView.php Normalize AuditStatusConstant Colors 2014-10-20 15:47:10 -07:00
DifferentialRevisionDetailView.php
DifferentialRevisionListView.php Use PhutilInvalidStateException 2015-05-14 07:53:52 +10:00
DifferentialRevisionUpdateHistoryView.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialTransactionView.php phtize all the things 2015-05-22 21:16:39 +10:00