1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/js/application/differential
epriestley ea67a8ab8e Make scrolling happen relative to the main content frame
Summary: Fixes T7033. When we've reframed the main page content we need to scroll relative to the containing frame, not relative to the window.

Test Plan:
In Safari, Chrome and Firefox, used j/k/J/K keys to navigate diff content.

Tried some other scroll-based beahviors, like jump-to-anchors.

(It looks like the highlighting reticle got slightly derped a while ago, but it's still functional, so I didn't mess with it.)

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7033

Differential Revision: https://secure.phabricator.com/D11490
2015-01-25 08:42:40 -08:00
..
behavior-add-reviewers-and-ccs.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-comment-jump.js Various minor JSHint fixes. 2014-07-01 06:00:12 +10:00
behavior-comment-preview.js Diffusion - nuke faulty javascript error handler 2014-08-28 13:08:32 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-dropdown-menus.js Use single quotes in JavaScript files 2015-01-20 08:53:47 +11:00
behavior-edit-inline-comments.js Various linter fixes. 2014-02-26 12:44:58 -08:00
behavior-keyboard-nav.js diffusion / differential - better handle case where no comment selected 2014-11-12 12:26:22 -08:00
behavior-populate.js Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
behavior-show-field-details.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-show-more.js Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00
behavior-toggle-files.js Better JS for Differential File Collapsing Undo 2013-08-13 16:14:26 -07:00
behavior-user-select.js Enable selecting text in Differential shield and gap 2012-09-20 15:20:47 -07:00
ChangesetViewManager.js Make scrolling happen relative to the main content frame 2015-01-25 08:42:40 -08:00
DifferentialInlineCommentEditor.js Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00