1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 19:32:40 +01:00
phorge-phorge/src/applications/maniphest/controller
epriestley 0e7a5623e3 Allow task statuses to "lock" them, preventing additional comments and interactions
Summary:
Ref T12335. See that task for discussion. Here are the behavioral changes:

  - Statuses can be flagged with `locked`, which means that tasks in that status are locked to further discussion and interaction.
  - A new "CAN_INTERACT" permission facilitates this. For most objects, "CAN_INTERACT" is just the same as "CAN_VIEW".
  - For tasks, "CAN_INTERACT" is everyone if the status is a normal status, and no one if the status is a locked status.
  - If a user doesn't have "Interact" permission:
    - They can not submit the comment form.
    - The comment form is replaced with text indicating "This thing is locked.".
    - The "Edit" workflow prompts them.

This is a mixture of advisory and hard policy checks but sholuld represent a reasonable starting point.

Test Plan: Created a new "Locked" status, locked a task. Couldn't comment, saw lock warning, saw lock prompt on edit. Unlocked a task.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12335

Differential Revision: https://secure.phabricator.com/D17453
2017-03-02 16:57:10 -08:00
..
ManiphestBatchEditController.php Update Batch Edit and Report pages 2016-04-05 07:24:47 -07:00
ManiphestController.php Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
ManiphestExportController.php Fix broken link to PHPExcel site 2016-08-03 14:06:53 +01:00
ManiphestReportController.php Update Batch Edit and Report pages 2016-04-05 07:24:47 -07:00
ManiphestSubpriorityController.php Partially update Maniphest for handleProcess 2015-08-01 17:06:57 -07:00
ManiphestTaskDetailController.php Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
ManiphestTaskEditController.php Rewrite workboards to have way more bugs 2016-02-10 13:08:38 -08:00
ManiphestTaskListController.php Partially update Maniphest for handleProcess 2015-08-01 17:06:57 -07:00