phorge-phorge/resources/sql/autopatches/20151108.xhpast.stderr.sql at eade206625ea1ec1e6946c379c9c24eb7c629534 - revi-archive/phorge-phorge - SiliconForest Atelier

revi-archive/phorge-phorge

mirror of https://we.phorge.it/source/phorge.git synced 2024-12-21 04:50:55 +01:00

Joshua Spence a2f909f0bd Improve XHPAST handling of syntax errors

Summary: Currently, a bunch of developers are using #xhpast for writing custom linter rules. As such, we end up with a fair few `XHPASTSyntaxErrorException` in our PHP error logs. I think that throwing an exception is not quite correct in this case because it is somewhat expected that invalid PHP may be entered. Instead, catch the exception and show the user a helpful message.

Test Plan: This doesn't quite work yet... the stream and tree views render as blank but the exceptions still propogate to the error logs. Mostly, I'm not sure how the exception should be rendered for display.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14028

2015-11-09 07:03:32 +11:00

5 lines

203 B

SQL

Raw Blame History

 ALTER TABLE {$NAMESPACE}_xhpastview.xhpastview_parsetree
   ADD returnCode INT NOT NULL AFTER input;
 ALTER TABLE {$NAMESPACE}_xhpastview.xhpastview_parsetree
   ADD stderr longtext NOT NULL AFTER stdout;