revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley eb397a48b4 Detect and prompt for passwords on SSH private keys, then strip them 
Summary:
Fixes T4356. Currently, if users add a passworded private key to the Passphrase application, we never ask for the password and can not use it later. This makes several changes:

  - Prompt for the password.
  - Detect passworded private keys, and don't accept them until we can decrypt them.
  - Try to decrypt passworded private keys, and tell the user if the password is missing or incorrect.
  - Stop further creation of path-based private keys, which are really just for compatibility. We can't do anything reasonable about passwords with these, since users can change the files.

Test Plan: Created a private key with a password, was prompted to provide it, tried empty/bad passwords, provided the correct password and had the key decrypted for use.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4356

Differential Revision: https://secure.phabricator.com/D8102
2014-01-30 11:43:06 -08:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00
auth Add very basic "quick create" menu 2014-01-28 20:18:01 -08:00
base Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
cache Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
calendar Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
chatlog Provide convenience method addTextCrumb() to PhabricatorCrumbsView 2013-12-18 17:47:34 -08:00
conduit Add diffusion.querycommits and deprecate diffusion.getcommits 2014-01-27 17:14:21 -08:00
config Mailgun receive support 2014-01-21 10:36:33 -08:00
conpherence Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
countdown Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
daemon Do not perform write in PhabricatorDaemonLogQuery by default 2014-01-21 14:04:12 -08:00
differential Add Disabled mode to landing revision ui 2014-01-30 09:07:50 -08:00
diffusion Use new "%R" escape for csprintf() to produce slightly nicer clone/checkout commands 2014-01-30 11:42:33 -08:00
diviner Add very basic "quick create" menu 2014-01-28 20:18:01 -08:00
doorkeeper Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
draft/storage Add draft support to ApplicationTransactions 2012-12-21 05:57:14 -08:00
drydock Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
fact Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
feed Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
files Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
flag Work around a bug in PHP 5.3-ish with abstract methods in interfaces 2013-10-25 15:58:17 -07:00
harbormaster Distinguish between "Remote URI" and "Clone URI" in Repositories 2014-01-30 11:41:21 -08:00
help/controller Make Differential views capability-sensitive 2013-09-26 18:45:04 -07:00
herald Add a "branches" rule for commits 2014-01-28 14:43:13 -08:00
home Make the quick create menu more or less work correctly 2014-01-28 20:19:20 -08:00
legalpad Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
lipsum Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
macro Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
mailinglists Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
maniphest Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
meta Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
metamta Mailgun receive support 2014-01-21 10:36:33 -08:00
notification Add dates to notifications page 2014-01-22 20:09:32 -08:00
nuance Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
oauthserver Initialize used variable 2013-07-09 21:55:27 -07:00
owners Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
passphrase Detect and prompt for passwords on SSH private keys, then strip them 2014-01-30 11:43:06 -08:00
paste Remove quick create buttons from application launcher 2014-01-29 17:23:50 -08:00
people Add very basic "quick create" menu 2014-01-28 20:18:01 -08:00
phame Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
phid Make Drydock Lease and Resource PHIDs use newer PHID infrastructure 2013-12-26 12:29:58 -08:00
phlux Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
pholio Add "Calendar Event" and "Pholio Mock" to quick create menu 2014-01-29 15:41:30 -08:00
phortune Provide convenience method addTextCrumb() to PhabricatorCrumbsView 2013-12-18 17:47:34 -08:00
phpast Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
phragment Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
phrequent Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
phriction Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00
policy Legalpad - add policy rule for legalpad document signatures 2014-01-15 16:48:44 -08:00
ponder Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
project Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00
releeph Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
remarkup/conduit Support processing Remarkup in bulk with remarkup.processbulk Conduit method 2013-11-02 16:30:11 -07:00
repository Allow Git and Mercurial repositories to be cloned with names in the URI 2014-01-30 11:42:25 -08:00
search Perform search indexing in the worker queue and respect bin/search index --background 2014-01-14 13:22:56 -08:00
settings Add very basic "quick create" menu 2014-01-28 20:18:01 -08:00
slowvote Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
subscriptions Tie application event listeners to the applications they listen for 2013-10-21 17:00:21 -07:00
system Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
tokens Provide convenience method addTextCrumb() to PhabricatorCrumbsView 2013-12-18 17:47:34 -08:00
transactions Add "Clone As" to repositories and generate full clone commands in UI 2014-01-30 11:42:10 -08:00
typeahead Legalpad - add policy rule for legalpad document signatures 2014-01-15 16:48:44 -08:00
uiexample Add OK icon. It's ok. 2014-01-15 08:00:55 -08:00
xhprof Make most file reads policy-aware 2013-09-30 09:38:13 -07:00