1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 18:32:41 +01:00
phorge-phorge/src/applications/repository/controller
epriestley ebc2937dc8 render_tag -> tag: final block
Summary:
Convert a final few `render_tag()` calls to `tag()` calls. This leaves us with 36 calls:

  - 9 are in Conpherence, and will be converted after merging. Using Views makes the most sense here, to get access to renderHTMLView() and such.
  - 2 are the definition and its library map entry.
  - 3 are in the documentation.
  - I believe the remaining 22 are too difficult to convert pre-merge. About half are in code which is slated for destruction; the other half are in the base implementations of very common classes (like PhabricatorStandardPageView) and can only be converted by converting the entire codebase.

My plan at this point is:

  - Test the branch thoroughly.
  - Merge to master.
  - Over time, resolve the remaining issues: lint means things shouldn't get any worse.

Test Plan: See inlines.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4802
2013-02-04 11:38:04 -08:00
..
PhabricatorRepositoryArcanistProjectDeleteController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorRepositoryArcanistProjectEditController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorRepositoryController.php Convert phutil_render_tag(X, Y, '...') to phutil_tag 2013-01-24 19:20:27 -08:00
PhabricatorRepositoryCreateController.php Panel background changes for Repositories app. 2013-01-16 07:49:24 -08:00
PhabricatorRepositoryDeleteController.php Fix some easy phutil_render_tag() 2013-01-25 11:39:23 -08:00
PhabricatorRepositoryEditController.php Convert phutil_render_tag(X, Y, '...') to phutil_tag 2013-01-24 19:20:27 -08:00
PhabricatorRepositoryListController.php render_tag -> tag: final block 2013-02-04 11:38:04 -08:00