1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-22 12:41:19 +01:00
phorge-phorge/src
epriestley d6e47eef19 Don't set a default "group by priority" in the task search engine
Summary:
See PHI42. Currently, `maniphest.search` incorrectly applies this default (group by priority) to all queries via Conduit.

The correct behavior is to apply no grouping constraint.

I think this is also a reasonable general behavior, and the current code seems to date from D6960 in 2013 and didn't seem particularly carefully considered.

This is a minor compatibility break -- saved queries which are more than 4 years old might change their group behavior. I'll note this in the change logs but expect essentially no one to be affected.

Test Plan: Ran a `maniphest.search` Conduit call and observed the underlying query. Before this change, it executed `ORDER BY priority, id`. After this change, it correctly executed `ORDER BY id` only.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18459
2017-08-24 12:37:44 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Pass all Throwables to Exception Handlers, not just Exceptions 2017-06-20 05:44:51 -07:00
applications Don't set a default "group by priority" in the task search engine 2017-08-24 12:37:44 -07:00
docs Add Home menu default Dashboard documentation 2017-08-23 09:28:20 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Continue reducing callsites to ArcanistDifferentialRevisionStatus 2017-08-09 11:05:22 -07:00
view Add a UIExamples page for PHUIBigInfoView 2017-08-07 15:58:49 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Allow more granularity on real-time notifications 2017-08-23 14:45:13 -07:00