mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-20 01:08:50 +02:00
77ef38f9a8
Summary: Ref T12819. This addresses two issues: - One practical issue is that right now, if you search for "dog cat", and they appear in different fields (for example, "dog" appears ONLY in the title, while "cat" appears ONLY in a comment) we won't find the document. This is somewhat rare -- usually, if "dog" appears in the title, it's also repeated in the description -- but I think clearly a bug. To attack this, start automatically creating a virtual "ALL" field with the full document text which we'll use as the primary thing we match against. - For fields which may occur more than once -- today, only comments -- aggregate them all into one big "all of the text" row instead of writing one row per comment. This partly addresses the first point ("dog" in one comment and "cat" in a different comment won't be found) and partly makes some of the query gymnastics easier. Test Plan: Ran `bin/storage upgrade`, ran `bin/search index <Txxx>`, saw sensible corpus values in the database: ``` mysql> select * from maniphest_task_ffield\G *************************** 1. row *************************** id: 3 documentID: 1981 fieldKey: full rawCorpus: This is the task title This is the task description. normalCorpus: thi the task titl thi the task descript *************************** 2. row *************************** id: 4 documentID: 1981 fieldKey: titl rawCorpus: This is the task title normalCorpus: thi the task titl *************************** 3. row *************************** id: 5 documentID: 1981 fieldKey: body rawCorpus: This is the task description. normalCorpus: thi the task descript 3 rows in set (0.00 sec) ``` Reviewers: chad Reviewed By: chad Maniphest Tasks: T12819 Differential Revision: https://secure.phabricator.com/D18497
4 lines
180 B
SQL
4 lines
180 B
SQL
TRUNCATE TABLE {$NAMESPACE}_maniphest.maniphest_task_ffield;
|
|
|
|
ALTER TABLE {$NAMESPACE}_maniphest.maniphest_task_ffield
|
|
ADD UNIQUE KEY `key_documentfield` (documentID, fieldKey);
|