1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
phorge-phorge/src
Andre Klapper ddcdd6eaf2 Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word
Summary:
The PHPDoc in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/storage/lisk/LiskMigrationIterator.php$14 defines `* @task storage`.
That means the value of `$task` in the DivinerAtomController class is the single string `storage` and there is no whitespace to `explode` on and there is no second key in the array to set as `$title`.
Thus only call `explode` when `$task` contains a whitespace.

```
EXCEPTION: (RuntimeException) Undefined array key 1 at [<arcanist>/src/error/PhutilErrorHandler.php:273]
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/diviner/controller/DivinerAtomController.php:450]
```

Closes T15854

Test Plan: Go to https://we.phorge.it/book/contrib/article/database/#primary-keys and click the `LiskMigrationIterator` link pointing to https://we.phorge.it/book/dev/class/LiskMigrationIterator/

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15854

Differential Revision: https://we.phorge.it/D25690
2024-06-22 18:10:23 +02:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Correct PHPDoc or add default return for numerous methods 2024-05-18 21:54:51 +02:00
applications Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word 2024-06-22 18:10:23 +02:00
docs Add Standard Custom Fields to Item List 2024-06-21 12:43:18 +03:00
extensions
infrastructure Add Standard Custom Fields to Item List 2024-06-21 12:43:18 +03:00
view Curtain: add Hovercard support 2023-12-10 16:55:14 +01:00
__phutil_library_init__.php Rebrand: Rename library and update "version" logic 2022-08-25 01:26:21 -07:00
__phutil_library_map__.php Conduit API: allow phriction.edit to modify viewPolicy and editPolicy 2024-06-21 18:10:30 +02:00