mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-22 18:28:47 +02:00
ef85f49adc
Summary: This commit doesn't change license of any file. It just makes the license implicit (inherited from LICENSE file in the root directory). We are removing the headers for these reasons: - It wastes space in editors, less code is visible in editor upon opening a file. - It brings noise to diff of the first change of any file every year. - It confuses Git file copy detection when creating small files. - We don't have an explicit license header in other files (JS, CSS, images, documentation). - Using license header in every file is not obligatory: http://www.apache.org/dev/apply-license.html#new. This change is approved by Alma Chao (Lead Open Source and IP Counsel at Facebook). Test Plan: Verified that the license survived only in LICENSE file and that it didn't modify externals. Reviewers: epriestley, davidrecordon Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2035 Differential Revision: https://secure.phabricator.com/D3886
79 lines
1.9 KiB
PHP
79 lines
1.9 KiB
PHP
<?php
|
|
|
|
final class DiffusionInlineCommentController
|
|
extends PhabricatorInlineCommentController {
|
|
|
|
private $commitPHID;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->commitPHID = $data['phid'];
|
|
}
|
|
|
|
protected function createComment() {
|
|
|
|
// Verify commit and path correspond to actual objects.
|
|
$commit_phid = $this->commitPHID;
|
|
$path_id = $this->getChangesetID();
|
|
|
|
$commit = id(new PhabricatorRepositoryCommit())->loadOneWhere(
|
|
'phid = %s',
|
|
$commit_phid);
|
|
if (!$commit) {
|
|
throw new Exception("Invalid commit ID!");
|
|
}
|
|
|
|
// TODO: Write a real PathQuery object?
|
|
|
|
$path = queryfx_one(
|
|
id(new PhabricatorRepository())->establishConnection('r'),
|
|
'SELECT path FROM %T WHERE id = %d',
|
|
PhabricatorRepository::TABLE_PATH,
|
|
$path_id);
|
|
|
|
if (!$path) {
|
|
throw new Exception("Invalid path ID!");
|
|
}
|
|
|
|
return id(new PhabricatorAuditInlineComment())
|
|
->setCommitPHID($commit_phid)
|
|
->setPathID($path_id);
|
|
}
|
|
|
|
protected function loadComment($id) {
|
|
return id(new PhabricatorAuditInlineComment())->load($id);
|
|
}
|
|
|
|
protected function loadCommentForEdit($id) {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$inline = $this->loadComment($id);
|
|
if (!$this->canEditInlineComment($user, $inline)) {
|
|
throw new Exception("That comment is not editable!");
|
|
}
|
|
return $inline;
|
|
}
|
|
|
|
private function canEditInlineComment(
|
|
PhabricatorUser $user,
|
|
PhabricatorAuditInlineComment $inline) {
|
|
|
|
// Only the author may edit a comment.
|
|
if ($inline->getAuthorPHID() != $user->getPHID()) {
|
|
return false;
|
|
}
|
|
|
|
// Saved comments may not be edited.
|
|
if ($inline->getAuditCommentID()) {
|
|
return false;
|
|
}
|
|
|
|
// Inline must be attached to the active revision.
|
|
if ($inline->getCommitPHID() != $this->commitPHID) {
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
}
|