1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 16:16:14 +01:00
phorge-phorge/src/applications/harbormaster/storage/build
epriestley ee0ad4703e Make the new Build Plan "Runnable" behavior work
Summary:
Ref T13258. Fixes T11415. This makes "Runnable" actually do something:

  - With "Runnable" set to "If Editable" (default): to manually run, pause, resume, abort, or restart a build, you must normally be able to edit the associated build plan.
  - If you toggle "Runnable" to "If Viewable", anyone who can view the build plan may take these actions.

This is pretty straightforward since T9614 already got us pretty close to this ruleset a while ago.

Test Plan:
  - Created a Build Plan, set "Can Edit" to just me, toggled "Runnable" to "If Viewable"/"If Editable", tried to take actions as another user.
  - With "If Editable", unable to run, pause, resume, abort, or restart as another user.
  - With "If Viewable", those actions work.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13258, T11415

Differential Revision: https://secure.phabricator.com/D20229
2019-03-06 06:01:02 -08:00
..
HarbormasterBuild.php Make the new Build Plan "Runnable" behavior work 2019-03-06 06:01:02 -08:00
HarbormasterBuildArtifact.php Make Harbormaster objects destructible 2018-03-29 13:01:14 -07:00
HarbormasterBuildLintMessage.php Allow lint codes to be up to 128 bytes long 2015-09-25 10:42:57 -07:00
HarbormasterBuildLog.php Count lines in build log slices more cheaply 2018-07-30 08:25:17 -07:00
HarbormasterBuildLogChunk.php When showing a small piece of a Harbormaster build log, load a small piece of data instead of the entire log 2018-02-28 12:32:26 -08:00
HarbormasterBuildLogChunkIterator.php Add a "filePHID" to HarbormasterBuildLog and copy logs into Files during finalization 2018-02-26 17:52:39 -08:00
HarbormasterBuildTarget.php Add support for "harbormaster.target.search" 2018-11-28 13:49:27 -08:00
HarbormasterBuildUnitMessage.php Allow unit tests to have arbitrarily long names (>255 characters) 2019-02-19 11:21:42 -08:00