mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-22 19:49:02 +01:00
0ca7c77c10
Summary: Fixes T2214. For objects which support ApplicationTransaction, use ApplicationTransactions to apply subscription action changes. Principally, this makes clicking "Subscribe" / "Unsubscribe" appear correctly in the transaction log. Test Plan: Clicked "Subscribe" and "Unsubscribe" a on Macros and Mocks. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2214 Differential Revision: https://secure.phabricator.com/D4986
123 lines
3.4 KiB
PHP
123 lines
3.4 KiB
PHP
<?php
|
|
|
|
final class PhabricatorSubscriptionsEditController
|
|
extends PhabricatorController {
|
|
|
|
private $phid;
|
|
private $action;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->phid = idx($data, 'phid');
|
|
$this->action = idx($data, 'action');
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
|
|
if (!$request->isFormPost()) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
switch ($this->action) {
|
|
case 'add':
|
|
$is_add = true;
|
|
break;
|
|
case 'delete':
|
|
$is_add = false;
|
|
break;
|
|
default:
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$user = $request->getUser();
|
|
$phid = $this->phid;
|
|
|
|
// TODO: This is a policy test because `loadObjects()` is not currently
|
|
// policy-aware. Once it is, we can collapse this.
|
|
$handle = PhabricatorObjectHandleData::loadOneHandle($phid, $user);
|
|
if (!$handle->isComplete()) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$objects = id(new PhabricatorObjectHandleData(array($phid)))
|
|
->setViewer($user)
|
|
->loadObjects();
|
|
$object = idx($objects, $phid);
|
|
|
|
if (!($object instanceof PhabricatorSubscribableInterface)) {
|
|
return $this->buildErrorResponse(
|
|
pht('Bad Object'),
|
|
pht('This object is not subscribable.'),
|
|
$handle->getURI());
|
|
}
|
|
|
|
if ($object->isAutomaticallySubscribed($user->getPHID())) {
|
|
return $this->buildErrorResponse(
|
|
pht('Automatically Subscribed'),
|
|
pht('You are automatically subscribed to this object.'),
|
|
$handle->getURI());
|
|
}
|
|
|
|
if ($object instanceof PhabricatorApplicationTransactionInterface) {
|
|
if ($is_add) {
|
|
$xaction_value = array(
|
|
'+' => array($user->getPHID()),
|
|
);
|
|
} else {
|
|
$xaction_value = array(
|
|
'-' => array($user->getPHID()),
|
|
);
|
|
}
|
|
|
|
$xaction = id($object->getApplicationTransactionObject())
|
|
->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS)
|
|
->setNewValue($xaction_value);
|
|
|
|
$editor = id($object->getApplicationTransactionEditor())
|
|
->setActor($user)
|
|
->setContinueOnNoEffect(true)
|
|
->setContentSource(
|
|
PhabricatorContentSource::newForSource(
|
|
PhabricatorContentSource::SOURCE_WEB,
|
|
array(
|
|
'ip' => $request->getRemoteAddr(),
|
|
)));
|
|
|
|
$editor->applyTransactions($object, array($xaction));
|
|
} else {
|
|
|
|
// TODO: Eventually, get rid of this once everything implements
|
|
// PhabriatorApplicationTransactionInterface.
|
|
|
|
$editor = id(new PhabricatorSubscriptionsEditor())
|
|
->setActor($user)
|
|
->setObject($object);
|
|
|
|
if ($is_add) {
|
|
$editor->subscribeExplicit(array($user->getPHID()), $explicit = true);
|
|
} else {
|
|
$editor->unsubscribe(array($user->getPHID()));
|
|
}
|
|
|
|
$editor->save();
|
|
}
|
|
|
|
// TODO: We should just render the "Unsubscribe" action and swap it out
|
|
// in the document for Ajax requests.
|
|
return id(new AphrontReloadResponse())->setURI($handle->getURI());
|
|
}
|
|
|
|
private function buildErrorResponse($title, $message, $uri) {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$dialog = id(new AphrontDialogView())
|
|
->setUser($user)
|
|
->setTitle($title)
|
|
->appendChild($message)
|
|
->addCancelButton($uri);
|
|
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
|
|
}
|