mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-21 21:10:56 +01:00
No description
ee6c24b98d
Summary: We need createlintresults because we are doing extended static analysis offline, and thus we need to be able to update the lint results associated with a diff. This is similar to updateunitresults, but "create" is more accurate than "update" since we never need to change existing lint results. getdiffproperty is used by the client to ensure it isn't creating any duplicates lint results. It's the symmetric operation to setdiffproperty, which already exists. Test Plan: We have a new offline linter that I used to test. This linter calls getdiffproperty on every run. 1. Tested updating an existing set of lint results by first running "arc diff" with lint errors caught by the local linter, then later running offline analysis which catches one other error and updates via createlintresults. Ensured the differential lint results were as expected. 2. Tested the creation of an entirely new diff property through createlintresults. I first ran "arc diff --nolint" to skip all lint results, then ran offline analysis which caught an error and updated through createlintresults. Ensured differential lint results were as expected. Reviewers: epriestley Reviewed By: epriestley CC: dpepper, aran, mgummelt, jungejason, epriestley Differential Revision: 868 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support/aphlict | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| .gitmodules | ||
| CHANGELOG | ||
| README | ||
Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. This is an early release. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0