1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
phorge-phorge/src/aphront
vrana eeb7d517c2 Always match full path in URI Mapper
Summary:
I am not sure if it is by purpose but Phabricator now process paths like
https://secure.phabricator.com/D1681-so-freaking-cool.
The reason is that there are bunch of rules with missing '$' at the end.
This mistake is so common and easy to create that I've rather removed all '$'
and changed the way how the key is processed.
I am not absolutelly sure if the '$' was missing in some rules by purpose but if
it is the case then we should rather add explicit '.*'.
This change is backwards compatible with custom maps ending with '$'. It is not
compatible with paths not ending with '$' by purpose.

Test Plan:
Visit /, /differential/, /differential/stats/revisions/, /D1681.
Run before and after:

  ./aphrontpath.php D123
  ./aphrontpath.php D123-cool
  ./aphrontpath.php /
  ./aphrontpath.php differential
  ./aphrontpath.php differential/
  ./aphrontpath.php differential/stats/revisions/
  ./aphrontpath.php /file/data/x/PHID-FILE-y/z

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1745
2012-03-01 15:27:03 -08:00
..
applicationconfiguration Automatically redirect 404's that wouldn't be 404s if they had a trailing slash 2011-04-04 10:29:46 -07:00
console Minor, fix number_format() warning. 2012-01-05 09:09:36 -08:00
controller Modularize oauth. 2011-02-27 20:38:11 -08:00
default Always match full path in URI Mapper 2012-03-01 15:27:03 -08:00
exception Fix conservative CSRF token cycling limit 2011-07-14 08:09:40 -07:00
mapper Always match full path in URI Mapper 2012-03-01 15:27:03 -08:00
request Improve error message for Conduit path problems 2012-01-16 11:48:21 -08:00
response OAuthServer polish and random sauce 2012-03-01 14:46:18 -08:00
sink Encode "<" and ">" in JSON/Ajax responses to prevent content-sniffing attacks 2012-02-14 14:51:51 -08:00
writeguard Create AphrontWriteGuard, a backup mechanism for CSRF validation 2011-08-16 13:29:57 -07:00