1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 15:22:41 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley ef30820cf4 Decrease fragility of conpherence-pontificate behavior
Summary:
Currently, this behavior binds a ton of IDs. This makes the behavior fragile: if it is invoked on a page without all the right elements, some `JX.$()` tends to explode.

Instead, don't assume anything is present on the page. This allows the behavior to be invoked on other pages (like the "New Conpherence" page) or pages without some elements (like some future thread-only mobile view) without creating JS errors.

Test Plan:
Added comments, added comments with files. Viewed "New conphenrece" page.

NOTE: Control+Enter is currently broken, but this diff didn't change that behavior.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5468
2013-03-31 14:41:13 -07:00
..
aphlict Add loading state to notification menu. 2013-01-28 17:35:17 -08:00
conpherence Decrease fragility of conpherence-pontificate behavior 2013-03-31 14:41:13 -07:00
core Remove drag-and-drop upload debugging code 2013-03-31 12:43:33 -07:00
countdown Make countdowns (internally) embeddable 2012-08-14 19:19:23 -07:00
differential Add a preference to completely disable the file tree 2013-02-04 17:00:27 -08:00
diffusion Load blame in Diffusion by AJAX 2013-03-06 07:44:45 -08:00
herald Clean up Login, Responsive Forms 2013-01-19 14:30:26 -08:00
maniphest Use ObjectItemListView for Maniphest 2013-03-23 14:38:01 -07:00
owners Allow excluding paths from package 2012-12-07 16:33:16 -08:00
phame Modernize blog UI 2012-10-15 14:50:12 -07:00
pholio Remarkup allows to point a specific image in a Mock set 2013-03-14 09:38:56 -07:00
phortune Phortune v0.1: add payment methods 2013-03-28 09:11:42 -07:00
phriction Add a document preview to Phriction 2011-07-16 18:48:27 -07:00
ponder Simplify upvote/downvote implementation 2012-09-30 20:12:35 -07:00
projects Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
releeph Releeph (Phabricator part) 2013-03-15 11:28:43 +00:00
repository Allow double click and drag in crossreference 2013-02-21 09:56:27 -08:00
transactions Make control + enter submit forms if a textarea is focused 2013-01-28 14:11:32 -08:00
uiexample Add support for device swipe events 2013-03-09 13:53:15 -08:00