1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-09 14:21:02 +01:00
phorge-phorge/src/applications/differential/storage
epriestley 03ab7224bb Reduce STATUS_CLOSED (now internally "Published") revision status callsites
Summary:
Ref T2543. Add `isPublished()` to mean: exactly the status 'closed', which is now interally called 'published', but still shown as 'closed' to users.

We have some callsites which are about "exactly that status", vs "any 'closed' status", e.g. including "abandoned".

This also introduces `isChangePlanned()`, which felt less awkward than `isChangesPlanned()` but more consistent than `hasChangesPlanned()` or `isStatusChangesPlanned()` or similar.

Test Plan: `grep`, loaded revisions, requested review.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18341
2017-08-09 11:05:42 -07:00
..
__tests__ Replace ArcanistPhutilTestCase refs with PhutilTestCase 2015-05-20 09:40:39 +10:00
DifferentialAffectedPath.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
DifferentialChangeset.php Allow users to "Force accept" package reviews if they own a more general package 2017-03-28 11:51:40 -07:00
DifferentialCustomFieldNumericIndex.php Various linter fixes. 2014-02-26 12:44:58 -08:00
DifferentialCustomFieldStorage.php Various linter fixes. 2014-02-26 12:44:58 -08:00
DifferentialCustomFieldStringIndex.php Various linter fixes. 2014-02-26 12:44:58 -08:00
DifferentialDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialDiff.php Navigage Buildkite builds with more nuance 2017-01-31 17:26:45 -08:00
DifferentialDiffProperty.php Fix almost all remaining schemata issues 2014-10-01 08:18:36 -07:00
DifferentialDiffTransaction.php Differential - make DifferentialDiffEditor into a real transaction editor. 2014-11-18 15:32:23 -08:00
DifferentialHiddenComment.php Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
DifferentialHunk.php Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
DifferentialInlineComment.php Build a page for viewing all inline comments 2017-06-12 11:31:20 -07:00
DifferentialLegacyHunk.php Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
DifferentialModernHunk.php Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
DifferentialReviewer.php Allow users to "Force accept" package reviews if they own a more general package 2017-03-28 11:51:40 -07:00
DifferentialRevision.php Reduce STATUS_CLOSED (now internally "Published") revision status callsites 2017-08-09 11:05:42 -07:00
DifferentialSchemaSpec.php Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
DifferentialTransaction.php Remove old code for "Request Review" action from Differential 2017-03-28 11:50:40 -07:00
DifferentialTransactionComment.php Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00