mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 02:02:41 +01:00
ca8f7cdaa5
Summary: Resolves T5831. This modifies the Drydock SSH interface to execute commands under Powershell when the target host platform is Windows. Powershell is far more featured than cmd.exe, and more closely resembles a UNIX shell. Currently Powershell outputs stderr as an XML blob on a line, and while this code currently doesn't use that, it will allow us in the future (planned next week) to redirect that output to the stderr log instead of having it all merged in with stdout under cmd (where there is no way to distinguish it). Test Plan: Ran various native commands and PowerShell commands from a Harbormaster build, including things like: ``` Write-Host ("my test" + ${build.id}) ``` and saw: ``` my test679 ``` in the output. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Maniphest Tasks: T5831 Differential Revision: https://secure.phabricator.com/D10248 |
||
|---|---|---|
| .. | ||
| HarbormasterBuildStepImplementation.php | ||
| HarbormasterCommandBuildStepImplementation.php | ||
| HarbormasterHTTPRequestBuildStepImplementation.php | ||
| HarbormasterLeaseHostBuildStepImplementation.php | ||
| HarbormasterPublishFragmentBuildStepImplementation.php | ||
| HarbormasterSleepBuildStepImplementation.php | ||
| HarbormasterThrowExceptionBuildStep.php | ||
| HarbormasterUploadArtifactBuildStepImplementation.php | ||
| HarbormasterWaitForPreviousBuildStepImplementation.php | ||