revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/differential/controller
History
vrana efed12400d Load all diff properties in revision view 
Summary:
We need to load all properties with some prefix in one field.
We can't merge them in one property because there will be a race condition for update (we don't have API for load+update+save).

Instead of providing API for this and complicating the code even more, just load everything unconditionally.
It shouldn't waste much bandwith or memory because we use most of the properties anyway.
It also looked overengineered to me.

Test Plan: Displayed revision with fields using diff properties.

Reviewers: epriestley, royw

Reviewed By: royw

CC: aran, royw, Korvin

Differential Revision: https://secure.phabricator.com/D3676
2012-10-10 13:43:21 -07:00
..
DifferentialChangesetViewController.php Set viewer for all handles loaded in controllers 2012-09-04 23:14:26 -07:00
DifferentialCommentPreviewController.php Don't store empty drafts 2012-10-01 16:05:39 -07:00
DifferentialCommentSaveController.php If users are on the email to Phabricator, do not send them the Phabricator reply. 2012-10-10 10:18:23 -07:00
DifferentialController.php Remove all code referencing old tab navigation 2012-08-13 15:28:41 -07:00
DifferentialDiffCreateController.php Remove all code referencing old tab navigation 2012-08-13 15:28:41 -07:00
DifferentialDiffViewController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
DifferentialInlineCommentEditController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
DifferentialInlineCommentPreviewController.php Make inline comment preview work in Diffusion 2012-07-23 11:01:28 -07:00
DifferentialRevisionDetailRenderer.php Pass target diff to revision detail renderer 2012-08-16 14:43:29 -07:00
DifferentialRevisionEditController.php If users are on the email to Phabricator, do not send them the Phabricator reply. 2012-10-10 10:18:23 -07:00
DifferentialRevisionListController.php Set viewer for all handles loaded in controllers 2012-09-04 23:14:26 -07:00
DifferentialRevisionStatsController.php Set viewer for all handles loaded in controllers 2012-09-04 23:14:26 -07:00
DifferentialRevisionViewController.php Load all diff properties in revision view 2012-10-10 13:43:21 -07:00
DifferentialSubscribeController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00