1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 17:58:47 +02:00
phorge-phorge/src/view
epriestley f0147fd8ad Allow workboards to be filtered with ApplicationSearch
Summary:
Ref T4673.

IMPORTANT: I had to break one thing (see TODO) to get this working. Not sure how you want to deal with that. I might be able to put the element //inside// the workboard, or I could write some JS. But I figured I'd get feedback first.

General areas for improvement:

  - It would be nice to give you some feedback that you have a filter applied.
  - It would be nice to let you save and quickly select common filters.
  - These would probably both be covered by a dropdown menu instead of a button, but that's more JS than I want to sign up for right now.
  - Managing custom filters is also a significant amount of extra UI to build.
  - Also, maybe these filters should be sticky per-board? Or across all boards? Or have a "make this my default view"? I tend to dislike implicit stickiness.

Test Plan:
Before:

{F157543}

Apply Filter:

{F157544}

Filtered:

{F157545}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: qgil, swisspol, epriestley

Maniphest Tasks: T4673

Differential Revision: https://secure.phabricator.com/D9211
2014-05-20 11:42:05 -07:00
..
__tests__ Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
control Convert rest of SPRITE_STATUS to FontAwesome 2014-05-18 16:10:54 -07:00
form Convert rest of SPRITE_STATUS to FontAwesome 2014-05-18 16:10:54 -07:00
layout Allow workboards to be filtered with ApplicationSearch 2014-05-20 11:42:05 -07:00
page Notifications - hide header dropdown if app is uninstalled 2014-05-14 10:08:07 -07:00
phui Don't hide action lists if there are no property list properties 2014-05-19 12:40:30 -07:00
widget Use standard UI elements to render pull requests in Releeph 2014-04-18 06:44:45 -07:00
AphrontDialogView.php Make errors in dialogs look reasonable instead of hideous 2014-04-03 11:23:03 -07:00
AphrontJavelinView.php Partial fix for Javelin View Example 2013-07-16 13:31:43 -07:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Remove all the container node stuff from AphrontTagView 2013-06-05 16:21:55 -07:00
AphrontView.php Allow CelerityResourceResponse to hold resources from multiple maps 2014-01-02 11:59:35 -08:00
viewutils.php Various linter fixes. 2014-02-26 12:44:58 -08:00