1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley f02aed10e7 Fix three issues with scrolling while dragging items (e.g., on workboards)
Summary:
Fixes T5979. There are three issues here:

  - We cache document positions when you pick an item up, but don't recalculate them after you scroll, so they get out of date. Dirty the cache when the user scrolls.
  - When we rebuild the cache during a drag (previously, this never happened), the position of the object you're dragging is computed wrong (since it has been moved to be under the cursor). Adjust the effective position of the object you've picked up to put it back in the right place in the list.
  - When you fiddle around at the bottom of a column you can get jumpy redraws as the height adjusts. Put `min-height` on the container during a drag to prevent this.

Test Plan: In Safari, Chrome and Firefox, dragged items around on columns before and after scrolling the workboard panel.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5979

Differential Revision: https://secure.phabricator.com/D10455
2014-09-09 14:20:27 -07:00
..
aphlict Show Aphlict connection status in notification menu 2014-06-23 16:26:16 -07:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
config Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
conpherence Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
countdown Fix countdown embeds and endless loops on resource loads in Javelin 2014-06-05 17:16:36 -07:00
dashboard Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
differential Diffusion - nuke faulty javascript error handler 2014-08-28 13:08:32 -07:00
diffusion Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
files Various linter fixes. 2014-02-26 12:44:58 -08:00
herald Support placeholder text in Herald 2014-07-17 15:55:43 -07:00
maniphest Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
owners Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
passphrase Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
phame Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
pholio Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
phortune Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
policy Mostly modernize the policy control typeahead 2014-07-17 15:56:20 -07:00
ponder Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
projects Fix three issues with scrolling while dragging items (e.g., on workboards) 2014-09-09 14:20:27 -07:00
releeph Remove @group annotations 2014-07-10 08:12:48 +10:00
repository Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
search Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
slowvote Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
transactions Transactions - add "view raw" action 2014-08-07 15:21:32 -07:00
uiexample Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00