1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
phorge-phorge/src/applications/phame
epriestley aaab1011e5 Give AphrontTagView a getViewer(), deprecate getUser()
Summary:
Two minor changes here:

  - Replace `get/setUser()` with `get/setViewer()` for consistency with everything else.
  - `getViewer()` now throws if no viewer is set. We had a lot of code that either "should" check this but didn't, or did check it in an identical way, duplicating work. In contrast, very little code checks for a viewer but works if one is not present.

Test Plan:
  - Grepped for `->user`.
  - Attempted to fix all callsites inside `*View` classes.
  - Browsed around a bunch of applications, particularly Calendar, Differential and Diffusion, which seemed most heavily affected.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15412
2016-03-06 09:27:38 -08:00
..
application Sync up UI with actual policy rules in Phame 2016-03-02 11:53:28 -08:00
capability Add Can Create Policy Capability to Phame Blogs 2015-11-08 07:00:18 -08:00
conduit Provide phame.post.edit Conduit API method 2015-12-28 06:55:35 -08:00
constants Add a transaction for PhamePost visibility 2015-11-07 06:52:58 -08:00
controller Sync up UI with actual policy rules in Phame 2016-03-02 11:53:28 -08:00
editor Sync up UI with actual policy rules in Phame 2016-03-02 11:53:28 -08:00
herald Add Herald Adapters to Phame 2016-01-05 14:10:43 -08:00
mail Allow mail replies to Phame Posts 2015-11-10 17:41:05 +00:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Add phame.post.search Conduit API endpoint 2015-12-28 06:49:43 -08:00
site Remove skins from Phame 2015-12-11 08:14:12 -08:00
storage Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
view Give AphrontTagView a getViewer(), deprecate getUser() 2016-03-06 09:27:38 -08:00