mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
5aca529980
Summary: Fixes T7563. Fixes T5201. Reframe this as two separate operations: - Move before or after a task. - Move to the beginning or end of a priority. Then: - Make all the order queries unambiguous and properly reversible, with an explicit `id` order. - Just reuse `ManiphestTask` to get results in the correct order. - Simplify the actual transaction apply logic. - Detect and recover from cases where tasks have identical or similar subpriorities. Test Plan: - Wrote and executed unit tests. - Dragged and dropped tasks within priorities and between priorities in the main Maniphest view. - Dragged and dropped tasks within priorities in the workboard view, when ordered by priority. - Also poked at the "natural" order, but that shouldn't be affected. Reviewers: btrahan, chad Reviewed By: chad Subscribers: chad, epriestley Maniphest Tasks: T5201, T7563 Differential Revision: https://secure.phabricator.com/D12121
68 lines
1.9 KiB
PHP
68 lines
1.9 KiB
PHP
<?php
|
|
|
|
final class ManiphestSubpriorityController extends ManiphestController {
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
if (!$request->validateCSRF()) {
|
|
return new Aphront403Response();
|
|
}
|
|
|
|
$task = id(new ManiphestTaskQuery())
|
|
->setViewer($user)
|
|
->withIDs(array($request->getInt('task')))
|
|
->needProjectPHIDs(true)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->executeOne();
|
|
if (!$task) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
if ($request->getInt('after')) {
|
|
$after_task = id(new ManiphestTaskQuery())
|
|
->setViewer($user)
|
|
->withIDs(array($request->getInt('after')))
|
|
->executeOne();
|
|
if (!$after_task) {
|
|
return new Aphront404Response();
|
|
}
|
|
list($pri, $sub) = ManiphestTransactionEditor::getAdjacentSubpriority(
|
|
$after_task,
|
|
$is_after = true);
|
|
} else {
|
|
list($pri, $sub) = ManiphestTransactionEditor::getEdgeSubpriority(
|
|
$request->getInt('priority'),
|
|
$is_end = false);
|
|
}
|
|
|
|
$xactions = array();
|
|
|
|
$xactions[] = id(new ManiphestTransaction())
|
|
->setTransactionType(ManiphestTransaction::TYPE_PRIORITY)
|
|
->setNewValue($pri);
|
|
|
|
$xactions[] = id(new ManiphestTransaction())
|
|
->setTransactionType(ManiphestTransaction::TYPE_SUBPRIORITY)
|
|
->setNewValue($sub);
|
|
|
|
$editor = id(new ManiphestTransactionEditor())
|
|
->setActor($user)
|
|
->setContinueOnMissingFields(true)
|
|
->setContinueOnNoEffect(true)
|
|
->setContentSourceFromRequest($request);
|
|
|
|
$editor->applyTransactions($task, $xactions);
|
|
|
|
return id(new AphrontAjaxResponse())->setContent(
|
|
array(
|
|
'tasks' => $this->renderSingleTask($task),
|
|
));
|
|
}
|
|
|
|
}
|