1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
No description
Find a file
epriestley f12dbe36d6 Raise a better error when a file upload fails in Differential
Summary:
Ref T2296. If a file upload fails (e.g., too large), we read the textarea from the "Create New Diff" interface. This means we show the user an error like "empty diff" when we should show them an error like "file upload failed, patch is too large". This is part of the issue in T2296, which features a 2.5MB diff.

Instead, check if a file was specified, so we'll raise a better error.

Test Plan: Tried to upload a large patch, got a "file is too large" error instead of an empty-diff-related error.

Reviewers: btrahan, vrana, codeblock

Reviewed By: codeblock

CC: aran

Maniphest Tasks: T2296

Differential Revision: https://secure.phabricator.com/D4369
2013-01-09 08:14:17 -08:00
bin Port Diviner Core to Phabricator 2013-01-07 14:04:23 -08:00
conf Port MySQL settings to PHP 2013-01-03 06:01:14 -08:00
externals one more phame tweak for better social sharing -- make sure $uri is the full uri 2012-12-21 13:46:23 -08:00
resources Store width and height metadata of image files 2013-01-07 09:46:43 -08:00
scripts Port Diviner Core to Phabricator 2013-01-07 14:04:23 -08:00
src Raise a better error when a file upload fails in Differential 2013-01-09 08:14:17 -08:00
support Consolidate environmental initialization 2012-12-25 06:15:28 -08:00
webroot Show current value in configuration list; show default vs non-default values 2013-01-01 14:11:39 -08:00
.arcconfig Delete license headers from files 2012-11-05 11:16:51 -08:00
.divinerconfig Centralize rendering of application mail bodies 2012-07-16 19:01:43 -07:00
.editorconfig Specify config for text editors 2012-11-03 22:34:44 -07:00
.gitignore Add a local configuration source and a non-environmental ENV config source 2012-12-30 06:16:15 -08:00
.gitmodules Just change the location. 2011-05-28 15:14:54 -07:00
LICENSE Delete license headers from files 2012-11-05 11:16:51 -08:00
NOTICE Increment year. 2013-01-03 05:45:08 -08:00
README Delete license headers from files 2012-11-05 11:16:51 -08:00

Phabricator is a open source collection of web applications which make it easier
to write, review, and share source code. Phabricator was developed at Facebook.

This is an early release. It's pretty high-quality and usable, but under
active development so things may change quickly.

You can learn more about the project and find links to documentation and
resources at: http://phabricator.org/

LICENSE

Phabricator is released under the Apache 2.0 license except as otherwise noted.