1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/phriction
Bob Trahan 905fc217b8 Phriction - validateTransactions that need parent ancestry to complete successfully
Summary:
Fixes T6651, T6682. Since policy is defined by ancestry, you can't make things outside the core tree.

An alternative fix would be to automagically stub everything in these cases. This has potential negative policy implications - consider making a public document with several levels of depth that automagically stubs out its ancestry as public - and additionally the PhabricatorApplicationTransactionEditor framework would make this very tricky code (i.e. you are expected to validateTransactions in said hook *and* return an error if things aren't valid and not do some automagic stubbing, etc.)

Test Plan: tried to move a doc from location/that/exists to locationz/thatz/dontz/existz/ and got an error message with links to each missing doc. tried to create a doc at locatonz/thatz/dontz/existsz/ and got an error message with links to each missing doc.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6682, T6651

Differential Revision: https://secure.phabricator.com/D10978
2014-12-12 11:35:43 -08:00
..
application Improve Phriction page move dialog 2014-11-12 07:04:51 -08:00
conduit Phriction - add "create" conduit endpoint 2014-11-07 11:46:25 -08:00
config Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
constants Remove @group annotations 2014-07-10 08:12:48 +10:00
controller Improve Phriction page move dialog 2014-11-12 07:04:51 -08:00
editor Phriction - validateTransactions that need parent ancestry to complete successfully 2014-12-12 11:35:43 -08:00
herald T4666, Support Herald in Phriction 2014-11-11 18:29:36 -08:00
mail Phriction - start the move towards transactions and an editor 2014-10-30 08:59:21 -07:00
markup Process Remarkup in text and HTML email bodies appropriately 2014-11-17 18:27:21 -08:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Fix minor issues with PhrictionDocumentQuery 2014-11-11 18:49:53 -08:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00