1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-19 16:58:48 +02:00
phorge-phorge/support/startup
Andre Klapper 123831b53f Drop question mark suffix from optional PHPDoc @param types
Summary:
The question mark in `@param type? $foo Desc` is a custom notation not consistently applied across the codebase and not necessarily obvious to the reader (because custom and not mentioned in https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md ).
Instead, explicitly state "optional" in the parameter description for clarity.

Closes T15925.

Test Plan: Run PHPStan, see no `PHPDoc @param has invalid value (type? [...]` style output anymore.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15925

Differential Revision: https://we.phorge.it/D25797
2024-09-06 19:17:00 +02:00
..
__tests__ Fix preamble-support 2023-04-10 01:13:52 -07:00
PhabricatorClientConnectionLimit.php
PhabricatorClientLimit.php Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
PhabricatorClientRateLimit.php Tweak rate limiting point counts for omnipotent users 2017-10-16 06:43:54 -07:00
PhabricatorStartup.php Drop question mark suffix from optional PHPDoc @param types 2024-09-06 19:17:00 +02:00
preamble-utils.php Drop question mark suffix from optional PHPDoc @param types 2024-09-06 19:17:00 +02:00