1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 10:52:41 +01:00
phorge-phorge/src/applications/config
epriestley 7ed6996604 Provide basic infrastructure for moving PHIDs, Handles and Object Names to applications
Summary:
See discussion in T2715. Currently, PHIDs are all hard coded in the PHID application. In the long run, we need to move them out into actual applications.

A specific immediate issue is Releeph, which uses a very very old and very broken mechanism to inject PHIDs in a way that only sort of works.

Moving forward, every PHID type will be provided by a `PhabricatorPHIDType` subclass, which will manage loading it, etc.

This also moves toward cleaning up the "load objects by name" (where "name" means something like `D12`) code, which is an //enormous// mess and spread across at least 4-5 callsites.

Test Plan: Used `phid.lookup` and `phid.query` to load Slowvotes.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6502
2013-07-21 06:34:21 -07:00
..
application Button to ignore setup issues + refractoring 2013-03-06 14:14:10 -08:00
check Provide basic infrastructure for moving PHIDs, Handles and Object Names to applications 2013-07-21 06:34:21 -07:00
controller Add arcanist and libphutil versions to /config/all/ 2013-07-18 12:41:03 -07:00
custom Allow configuration to have custom UI types 2013-06-07 12:36:18 -07:00
editor Use setContentSourceFromRequest() in more places 2013-05-24 10:48:34 -07:00
exception Allow configuration to be explicitly validated, including validation of complex attributes 2013-01-01 18:15:03 -08:00
issue Fixed T2630 2013-04-10 13:11:22 -07:00
json Mask remaining config values, and implement set type 2013-01-16 15:06:07 -08:00
management Make UX for misspelled or delted config much less bad 2013-06-26 11:01:19 -07:00
option Add explicit mysql.port configuration 2013-07-14 16:06:23 -07:00
query Use transactions to show edit history for Configuration 2013-01-01 18:14:41 -08:00
response [SECURITY] Prevented PhabricatorSetupIssueView from exposing sensitive config options. 2013-04-06 00:39:53 -07:00
storage Button to ignore setup issues + refractoring 2013-03-06 14:14:10 -08:00
view Make UX for misspelled or delted config much less bad 2013-06-26 11:01:19 -07:00