1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 09:22:40 +01:00
phorge-phorge/src/applications/macro
Bob Trahan 9838251515 Make PhabricatorActionListView logged-out user savvy
Summary:
Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI.

Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption.

Test Plan: played around with a mock all logged out (Ref T2652) and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2691

Differential Revision: https://secure.phabricator.com/D6416
2013-07-12 11:39:47 -07:00
..
application Add the quick shortcut to create an image macro. Maybe. 2013-07-02 20:27:15 -07:00
conduit Adding macro create method. 2013-07-08 19:49:05 -07:00
config MetaMTA: Owners, Pholio, Macro 2013-01-16 10:52:30 -08:00
constants Modernize Macro application 2012-12-11 14:01:03 -08:00
controller Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
editor Use transactions to show edit history for Configuration 2013-01-01 18:14:41 -08:00
mail Remove the last hardcoding from PhabricatorMetaMTAReceivedMail 2013-05-17 10:00:49 -07:00
query Add a date range query to Macros 2013-05-30 17:32:12 -07:00
remarkup Implement text mode for Phabricator Remarkup rules 2013-03-22 17:33:36 -07:00
storage Store authors on image macros 2013-05-29 15:05:44 -07:00