1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 02:02:41 +01:00
phorge-phorge/src/applications/audit
epriestley 65634781b4 Don't re-mention users for comment edits
Summary:
Ref T11035. This only fixes half of the issue: comment editing has been fixed, but normal transactions which edit things like descriptions haven't yet.

The normal edits aren't fixed because the "oldValues" are populated too late. The code should start working once they get populated sooner, but I don't want to jump the gun on that since it'll probably have some spooky effects. I have some other transaction changes coming down the pipe which should provide a better context for testing "oldValue" population order.

Test Plan:
  - Mentioned `@dog` in a comment.
  - Removed `@dog` as a subscriber.
  - Edited the comment, adding some unrelated text at the end (e.g., fixing a typo).
    - Before change: `@dog` re-added as subscriber.
    - After change: no re-add.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11035

Differential Revision: https://secure.phabricator.com/D16108
2016-06-13 13:57:59 -07:00
..
application Correct tooltip label for open audit count 2016-06-01 07:12:10 -07:00
conduit Load audit requests when querying audits 2015-09-25 10:43:17 -07:00
constants Update Diffusion UI 2016-03-17 12:05:14 -07:00
controller Fix two issues with callsign-free repositories 2016-02-26 06:13:46 -08:00
editor Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
mail Move commits to the "COMMIT" mail prefix 2015-09-25 10:43:11 -07:00
management Remove various additional calls to getCallsign() 2016-01-02 11:04:22 -08:00
query More NUX states 2015-12-21 13:13:44 -08:00
storage Modularize content sources 2016-03-26 11:59:45 -07:00
view [Redesign] Misc batch of UI buggypoos 2015-06-19 13:18:42 +01:00