mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 10:22:42 +01:00
be235301d0
Summary: Ref T11522. This tries to reduce the cost of rewriting a repository by making handles smarter about rewritten commits. When a handle references an unreachable commit, try to load a rewrite hint for the commit. If we find one, change the handle name to "OldHash > NewHash" to provide a strong hint that the commit was rewritten and that copy/pasting the old hash (say, to the CLI) won't work. I think this notation isn't totally self-evident, but users can click it to see the big error message on the page, and it's at least obvious that something weird is going on, which I think is the important part. Some possible future work: - Not sure this ("Recycling Symbol") is the best symbol? Seems sort of reasonable but mabye there's a better one. - Putting this information directly on the hovercard could help explain what this means. Test Plan: {F1780719} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11522 Differential Revision: https://secure.phabricator.com/D16437
47 lines
1.3 KiB
PHP
47 lines
1.3 KiB
PHP
<?php
|
|
|
|
final class DiffusionCommitRemarkupRule extends PhabricatorObjectRemarkupRule {
|
|
|
|
protected function getObjectNamePrefix() {
|
|
return '';
|
|
}
|
|
|
|
protected function getObjectNamePrefixBeginsWithWordCharacter() {
|
|
return true;
|
|
}
|
|
|
|
protected function getObjectIDPattern() {
|
|
return PhabricatorRepositoryCommitPHIDType::getCommitObjectNamePattern();
|
|
}
|
|
|
|
protected function getObjectNameText(
|
|
$object,
|
|
PhabricatorObjectHandle $handle,
|
|
$id) {
|
|
|
|
// If this commit is unreachable, return the handle name instead of the
|
|
// normal text because it may be able to tell the user that the commit
|
|
// was rewritten and where to find the new one.
|
|
|
|
// By default, we try to preserve what the user actually typed as
|
|
// faithfully as possible, but if they're referencing a deleted commit
|
|
// it's more valuable to try to pick up any rewrite. See T11522.
|
|
if ($object->isUnreachable()) {
|
|
return $handle->getName();
|
|
}
|
|
|
|
return parent::getObjectNameText($object, $handle, $id);
|
|
}
|
|
|
|
protected function loadObjects(array $ids) {
|
|
$viewer = $this->getEngine()->getConfig('viewer');
|
|
|
|
$query = id(new DiffusionCommitQuery())
|
|
->setViewer($viewer)
|
|
->withIdentifiers($ids);
|
|
|
|
$query->execute();
|
|
return $query->getIdentifierMap();
|
|
}
|
|
|
|
}
|