1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-23 05:01:13 +01:00
phorge-phorge/src/applications/transactions
Valerio Bozzolan 3a8ee271d9 Render all Removed Comments a little more docile
Summary:
This small restyle makes any Removed Comment a little less
prominent than normal ones, with the goal of decreasing a
bit your in-page distractions and increase your individual
productivity in your business by at least 250 milliseconds
every 48 hours of hard work in front of your monitor.

| Before              | After               |
|---------------------|---------------------|
| {F274834,size=full} | {F274835,size=full} |

This implementation (which is called "Kasper on Diet")
contains these specific changes for Removed Comments:

- user icon visibility: reduced by ~50% (-> Kasper)
- black "trash" icon: reduced by ~50% (-> Diet)
- texts: visibility reduced by ~50%
- vertical padding: reduced from 16px down to 4px

Note that if your Phorge is under the Serious Business Mode,
it seems it is still technically possible to manually
activate the "Decaying Curse" proposal mentioned in the Task.

Closes T15192

Test Plan:
- Add a Comment "I love Phorge"
- Add a Comment "I love Phabricator"
- Mark the second Comment as Removed
- Call a person at your desk
- Plug that person to an eyeball tracker

If the general attention focuses first on a normal Comment and then
on the Removed Comment, this change works perfectly.

Reviewers: O1 Blessed Committers, Cigaryno, avivey

Reviewed By: O1 Blessed Committers, Cigaryno, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Tags: #comments

Maniphest Tasks: T15192

Differential Revision: https://we.phorge.it/D25096
2023-04-06 14:46:35 +02:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
bulk Fix an issue where the "viewer" is not passed to Bulk Edit controls properly 2019-09-26 12:03:49 -07:00
commentaction When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision" 2018-11-15 20:50:21 -08:00
conduit Remove product literal strings in "pht()", part 8 2022-04-25 12:22:29 -07:00
constants Double-write file attachment to old "edge" storage and new "attachment" storage 2022-05-19 13:21:03 -07:00
controller Inline custom policy rules inside policy capability explanation dialogs 2019-09-12 09:40:50 -07:00
data Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Remove file attachment edge types, including API access 2022-05-19 13:21:04 -07:00
editengine Give "FileAttachment" policy support and a query object 2022-05-23 14:08:15 -07:00
editfield Flatten "RemarkupValue" objects when setting field defaults for custom forms 2022-06-14 09:37:35 -07:00
editor Pass "object" to modular transaction methods explicitly 2022-05-25 10:25:18 -07:00
edittype Accept null via conduit.edit to unassign a task 2018-01-31 15:33:52 -08:00
engine Propagate the "ContextObject" to Remarkup rendering in timelines 2021-02-13 13:37:36 -08:00
engineextension Fix subtype extension support check 2021-08-20 18:49:35 -04:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception When users submit "editing" inlines, warn them that their inlines will be saved 2020-05-04 13:13:15 -07:00
feed Separate "feed" and "notifications" better, allow stories to appear in notifications only 2018-12-10 16:02:43 -08:00
herald Support "Subtype" in Herald 2019-09-12 14:34:06 -07:00
interface Allow inline comment storage objects to generate their own runtime objects 2020-05-07 15:57:49 -07:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
replyhandler Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
response When users submit "editing" inlines, warn them that their inlines will be saved 2020-05-04 13:13:15 -07:00
storage Render all Removed Comments a little more docile 2023-04-06 14:46:35 +02:00
typeahead Support filtering feed transactions by object type 2019-05-21 12:39:10 -07:00
view Render all Removed Comments a little more docile 2023-04-06 14:46:35 +02:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects 2019-08-28 06:57:04 -07:00