1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/transactions
epriestley f4f73e0a7e Separate fulltext engine extensions into "enrich" and "index" phases
Summary:
Ref T12819. Some of the extensions "enrich" the document (adding more fields or relationships), while others "index" it (insert it into some kind of index for later searching).

Currently, these are all muddled under a single "index" phase. However, the Ferret extension cares about fields and relationships which other extensions may add.

Split this into two phases: "enrich" adds fields and relationships so other extensions can read them later if they want. "Index" happens after the document is built and has all the fields and relationships.

The specific problem this solves is that comments may not have been added to the document when the Ferret extension runs. By moving them to the "enrich" phase, the Ferret engine will be able to see and index comments.

Test Plan: Ran `bin/search index ...`, grepped for `indexFulltextDocument`.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12819

Differential Revision: https://secure.phabricator.com/D18513
2017-09-01 09:40:11 -07:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
commentaction When accepting revisions, allow users to accept on behalf of a subset of reviewers 2017-03-22 14:25:04 -07:00
conduit Provide some more detailed information about inline comments in "transaction.search" 2017-08-24 15:26:50 -07:00
constants When an object which supports subtypes is created, set its subtype to the creating form's subtype 2017-03-02 04:18:23 -08:00
controller Remove duplicate "Change Default Values" action in form editing workflow 2017-03-22 09:50:38 -07:00
data Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Add a generic "edge.search" method 2017-03-04 15:26:29 -08:00
editengine Update Settings to use TwoColumn fixed layout 2017-08-17 08:51:17 -07:00
editfield Let "<select />" EditEngine fields canonicalize saved defaults 2017-06-20 17:42:33 -07:00
editor Slightly simplify logic for determining if an inline comment has an effect 2017-08-24 15:26:32 -07:00
edittype Make stored custom fields work with v3 EditEngine API 2016-12-16 10:09:03 -08:00
engineextension Separate fulltext engine extensions into "enrich" and "index" phases 2017-09-01 09:40:11 -07:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception Mark some strings for translation 2015-06-09 23:06:52 +10:00
feed Add AuthorHref to feed story images 2017-02-07 10:09:00 -08:00
interface Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query When editing a subtyped object, use edit forms of the same subtype 2017-03-02 04:24:28 -08:00
replyhandler Modularize content sources 2016-03-26 11:59:45 -07:00
response Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00
storage Fix an issue where "Close Revision" did not appear in the UI 2017-08-29 09:58:48 -07:00
typeahead Don't allow forms which can't create objects to be added to profile menus 2017-02-16 15:45:11 -08:00
view Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Modularize application transactions in Paste, mostly 2016-06-14 06:13:28 -07:00