1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/infrastructure
epriestley f4f73e0a7e Separate fulltext engine extensions into "enrich" and "index" phases
Summary:
Ref T12819. Some of the extensions "enrich" the document (adding more fields or relationships), while others "index" it (insert it into some kind of index for later searching).

Currently, these are all muddled under a single "index" phase. However, the Ferret extension cares about fields and relationships which other extensions may add.

Split this into two phases: "enrich" adds fields and relationships so other extensions can read them later if they want. "Index" happens after the document is built and has all the fields and relationships.

The specific problem this solves is that comments may not have been added to the document when the Ferret extension runs. By moving them to the "enrich" phase, the Ferret engine will be able to see and index comments.

Test Plan: Ran `bin/search index ...`, grepped for `indexFulltextDocument`.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12819

Differential Revision: https://secure.phabricator.com/D18513
2017-09-01 09:40:11 -07:00
..
cluster Convert cluster/projects config options to newer modular structure 2017-06-27 12:35:54 -07:00
contentsource Redesign Config Application 2016-08-29 15:49:49 -07:00
customfield Separate fulltext engine extensions into "enrich" and "index" phases 2017-09-01 09:40:11 -07:00
daemon Fix a spelling error in worker triggers 2017-07-20 14:20:44 -07:00
diff Consider inline comments with draft checkmarks as "unsubmitted" 2017-06-15 05:22:58 -07:00
edges Add a generic "edge.search" method 2017-03-04 15:26:29 -08:00
env Throw an exception if local.json can't be read 2017-05-16 15:12:49 -07:00
events Modernize Hovercard implementation 2015-12-24 12:18:28 -08:00
graph Continue reducing callsites to ArcanistDifferentialRevisionStatus 2017-08-09 11:05:22 -07:00
internationalization Modernize PhortuneAccount with EditEngine/Modular Transactions 2017-04-11 12:33:15 -07:00
javelin When the profiler is active, keep it active if the user submits forms 2017-02-23 11:15:40 -08:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
log Add "%I" (instance name) to application log formats 2017-04-23 11:07:19 -07:00
management Provide "bin/files integrity" for debugging, maintaining and backfilling integrity hashes 2017-04-06 15:42:43 -07:00
markup Fix ambiguous URI parsing in Youtube Remarkup rule 2017-06-23 08:43:15 -07:00
query Add "title:..." support to the Ferret engine 2017-08-30 11:30:42 -07:00
sms Various linter fixes 2015-08-11 22:36:55 +10:00
ssh Normalize remote IP addresses when writing to logs, etc 2016-12-05 11:20:29 -08:00
storage Don't apply patches or mark patches applied with bin/storage upgrade --dryrun 2017-05-05 19:57:18 -07:00
syntax Pass the new default syntax highlighting map to the remarkup engine 2016-05-05 02:51:19 -07:00
testing When running unit tests, ignore any custom task fields 2017-04-02 09:36:17 -07:00
time Fix errors found by PHPStan 2017-02-18 09:24:56 +00:00
util Rename "PhabricatorHash::digest()" to "weakDigest()" 2017-04-06 15:43:33 -07:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00