mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-01 03:02:43 +01:00
20e4c3fbd4
Summary: Ref T9132. We have several places in the code that sometimes need to parse complex types. For example, we accept all of these in ApplicationSearch and now in ApplicationEditor: > /?subscribers=cat,dog > /?subscribers=PHID-USER-1111 > /?subscribers[]=cat&subscribers[]=PHID-USER-2222 ..etc. The logic to parse this stuff isn't too complex, but it isn't trivial either. Right now it lives in some odd places. Notably, `PhabricatorApplicationSearchEngine` has some weird helper methods for this stuff. Rather than give `EditEngine` the same set of weird helper methods, pull all this stuff out into "HTTPParameterTypes". Future diffs will add "Projects" and "Users" types where all the custom parsing/lookup logic can live. Then eventually the Search stuff can reuse these. Generally, this just breaks the code up into smaller pieces that have more specific responsibilities. Test Plan: {F944142} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9132 Differential Revision: https://secure.phabricator.com/D14402 |
||
|---|---|---|
| .. | ||
| PhabricatorConfigCollectorsModule.php | ||
| PhabricatorConfigEdgeModule.php | ||
| PhabricatorConfigHTTPParameterTypesModule.php | ||
| PhabricatorConfigModule.php | ||
| PhabricatorConfigPHIDModule.php | ||
| PhabricatorConfigRequestExceptionHandlerModule.php | ||
| PhabricatorConfigSiteModule.php | ||
| PhabricatorConfigVersionsModule.php | ||