epriestley 2914613444 Fix failure to record pullerPHID in repository pull logs ... Summary: See PHI305. Ref T13046. The SSH workflows currently extend `PhabricatorManagementWorkflow` to benefit from sharing all the standard argument parsing code. Sharing the parsing code is good, but it also means they inherit a `getViewer()` method which returns the ommnipotent viewer. This is appropriate for everything else which extends `ManagementWorkflow` (like `bin/storage`, `bin/auth`, etc.) but not appropriate for SSH workflows, which have a real user. This caused a bug with the pull logs where `pullerPHID` was not recorded properly. We used `$this->getViewer()->getPHID()` but the correct code was `$this->getUser()->getPHID()`. To harden this against future mistakes: - Don't extend `ManagementWorkflow`. Extend `PhutilArgumentWorkflow` instead. We **only** want the argument parsing code. - Rename `get/setUser()` to `get/setSSHUser()` to make them explicit. Then, fix the pull log bug by calling `getSSHUser()` instead of `getViewer()`. Test Plan: - Pulled and pushed to a repository over SSH. - Grepped all the SSH stuff for the altered symbols. - Saw pulls record a valid `pullerPHID` in the pull log. - Used `echo {} | ssh ... conduit conduit.ping` to test conduit over SSH. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13046 Differential Revision: https://secure.phabricator.com/D18912		2018-01-23 14:09:42 -08:00
..
ssh-auth-key.php	Deactivate SSH keys instead of destroying them completely	2016-05-18 14:54:28 -07:00
ssh-auth.php	Cache generation of the SSH authentication keyfile for sshd	2016-10-21 07:29:40 -07:00
ssh-connect.php	When available, use async_signals in Phabricator	2017-01-12 16:00:13 -08:00
ssh-exec.php	Fix failure to record pullerPHID in repository pull logs	2018-01-23 14:09:42 -08:00