1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/differential
epriestley dd501117e8 When deleting inline comments, offer "undo" instead of prompting
Summary:
Ref T2009. Ref T1460.

Fixes T2618. When users hit "Delete" on inline comments, delete immediately and offer them "Undo". If they delete indirectly (e.g., by clicking "Delete" from the preview at the bottom of the page), we still prompt them, because the "Undo" action either won't be available or may not be easy to find. This is a "refdelete".

Fixes T6464. This was just a mess. Make it not as much of a mess. It should work now. Pretty sure.

Fixes T4999. We did not refresh these links often enough to find targets for them, so they could race with content. Reevaluate them after loading new changes.

Test Plan:
  - Deleted and undid deletion of inlines from main view and preview.
  - Clicked "View" on inlines.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6464, T4999, T2618, T1460, T2009

Differential Revision: https://secure.phabricator.com/D12032
2015-03-09 17:27:51 -07:00
..
__tests__ Show a more tailored message when adding empty files 2015-03-09 10:27:18 -07:00
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Differential - add ability to setup "create" addresses for revisions 2015-01-30 10:31:39 -08:00
config Lock all reply-handler options in the upstream, plus cookie prefix 2015-02-13 11:00:09 -08:00
constants Differential - label unit / lint results from the commit diff as not applicable 2014-09-16 12:11:54 -07:00
controller Hide revision content if author has not signed required legal documents 2015-03-09 10:26:54 -07:00
customfield Fix visibility for DifferentialManiphestTasksField::readValueFromRevision 2015-01-14 07:04:36 +11:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Don't write inverse edges for DifferentialRevisionHasReviewerEdgeType 2015-01-04 10:07:56 +11:00
editor Write "hasReplies" to database for inline comments 2015-03-09 14:11:16 -07:00
event Fix pht method calls 2015-02-10 18:57:45 +11:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Explicitly declare method/property visibility 2015-01-12 08:18:13 +11:00
lipsum Remove an unused variable 2015-01-03 10:31:46 +11:00
mail MetaMTA - update documentation and make config a tad easier 2015-02-12 11:05:39 -08:00
management Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
parser Show a more tailored message when adding empty files 2015-03-09 10:27:18 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query When deleting inline comments, offer "undo" instead of prompting 2015-03-09 17:27:51 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Reduce code duplication in inline right/left side tracking 2015-03-09 12:53:40 -07:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage When deleting inline comments, offer "undo" instead of prompting 2015-03-09 17:27:51 -07:00
view Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
DifferentialGetWorkingCopy.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00