1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/settings/panel
epriestley 4f8d07594e Fix a CSRF issue with adding new email addresses
Summary:
The first dialog was being given the wrong user (`$user`, should be `$viewer`), leading to a CSRF issue.

(The CSRF token it generated was invalid in all validation contexts, so this wasn't a security problem or a way to capture CSRF tokens for other users.)

Use `newDialog()` instead.

(This seems completely unrelated to the vaguely-similar-looking issues we saw earlier this week.)

Test Plan:
  - Added a new email address.
  - Clicked "Done" on the last step.
  - Completed workflow instead of getting a CSRF error.

Reviewers: chad, tide

Reviewed By: tide

Differential Revision: https://secure.phabricator.com/D16200
2016-06-30 08:35:24 -07:00
..
PhabricatorAccountSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorActivitySettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorConpherencePreferencesSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorDateTimeSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorDesktopNotificationsSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorDeveloperPreferencesSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorDiffPreferencesSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorDisplayPreferencesSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorEditEngineSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorEmailAddressesSettingsPanel.php Fix a CSRF issue with adding new email addresses 2016-06-30 08:35:24 -07:00
PhabricatorEmailDeliverySettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorEmailFormatSettingsPanel.php Fix several issues with email-related global preferences 2016-06-14 12:35:31 -07:00
PhabricatorEmailPreferencesSettingsPanel.php Fix exception when trying to save global setting mail tags 2016-06-05 13:57:20 -07:00
PhabricatorExternalAccountsSettingsPanel.php Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
PhabricatorHomePreferencesSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorMultiFactorSettingsPanel.php Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
PhabricatorPasswordSettingsPanel.php Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
PhabricatorSessionsSettingsPanel.php Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
PhabricatorSettingsPanel.php Fix several issues with email-related global preferences 2016-06-14 12:35:31 -07:00
PhabricatorSSHKeysSettingsPanel.php Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
PhabricatorTokensSettingsPanel.php Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00